You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/12/05 12:37:26 UTC

[GitHub] stigsb commented on a change in pull request #107: Daemon set merge

stigsb commented on a change in pull request #107: Daemon set merge
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/107#discussion_r154931697
 
 

 ##########
 File path: kubernetes/invoker/invoker.yml
 ##########
 @@ -1,20 +1,29 @@
 ---
-apiVersion: apps/v1beta1
-kind: StatefulSet
+apiVersion: extensions/v1beta1
+kind: DaemonSet
 
 Review comment:
   First of all, thanks for your work on the OpenWhisk+Kubernetes integration!
   
   I know this has been merged already, but is this really what you want?  Using a DaemonSet will ensure only one instance per node, but you can do this in a Deployment as well, with node anti-affinity. This opens up the opportunity to use HorizontalPodAutoscaler and node pool autoscaling, and AFAICS it also removes the need to maintain node labels by default?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services