[GitHub] [hive] kgyrtkirk commented on a change in pull request #2641: HIVE-24975: Fixes a bug in ValidWriteIdList comparison in TxnIdUtils

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #2641:
URL: https://github.com/apache/hive/pull/2641#discussion_r765012114



##########
File path: storage-api/src/test/org/apache/hive/common/util/TestTxnIdUtils.java
##########
@@ -190,5 +191,15 @@ public void testCompareWriteIds() throws Exception {
         new ValidReaderWriteIdList("default.table2", new long[] {8,10,11}, new BitSet(), 11)),
     -1);
 
+    ValidWriteIdList a =

Review comment:
       putting a lot of cases into the same method is not really development friendly - next time please put new testcases into new test methods




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org