[GitHub] spark pull request #16722: [SPARK-9478][ML][MLlib] Add sample weights to dec...

[sethah <gi...@git.apache.org>]

Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16722#discussion_r98807054
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala ---
    @@ -106,14 +122,18 @@ class DecisionTreeClassifier @Since("1.4.0") (
             ".train() called with non-matching numClasses and thresholds.length." +
             s" numClasses=$numClasses, but thresholds has length ${$(thresholds).length}")
         }
    -
    -    val oldDataset: RDD[LabeledPoint] = extractLabeledPoints(dataset, numClasses)
    --- End diff --
    
    Good catch. Actually this problem exists elsewhere (LogisticRegression, e.g.) What to do you think about adding it back manually here and then addressing the larger issue in a separate JIRA?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org