You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by iv...@apache.org on 2011/02/14 19:25:49 UTC
svn commit: r1070600 - in /wicket/trunk:
wicket-core/src/main/java/org/apache/wicket/request/cycle/
wicket-core/src/test/java/org/apache/wicket/request/cycle/
wicket-request/src/main/java/org/apache/wicket/request/
Author: ivaynberg
Date: Mon Feb 14 18:25:49 2011
New Revision: 1070600
URL: http://svn.apache.org/viewvc?rev=1070600&view=rev
Log:
remove irequesthandlerexecutor interface. nothing is meant to replace the stack, so we dont need to put it behind an interface.
Issue: WICKET-3415
Removed:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/IRequestHandlerExecutor.java
Modified:
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/cycle/BaseRequestHandlerStackTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/cycle/RequestHandlerStackTest.java
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/RequestHandlerStack.java
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java?rev=1070600&r1=1070599&r2=1070600&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java Mon Feb 14 18:25:49 2011
@@ -26,7 +26,6 @@ import org.apache.wicket.event.IEventSin
import org.apache.wicket.request.IExceptionMapper;
import org.apache.wicket.request.IRequestCycle;
import org.apache.wicket.request.IRequestHandler;
-import org.apache.wicket.request.IRequestHandlerExecutor;
import org.apache.wicket.request.IRequestMapper;
import org.apache.wicket.request.Request;
import org.apache.wicket.request.RequestHandlerStack;
@@ -111,7 +110,7 @@ public class RequestCycle implements IRe
/** the time that this request cycle object was created. */
private final long startTime = System.currentTimeMillis();
- private IRequestHandlerExecutor requestHandlerExecutor;
+ private RequestHandlerStack requestHandlerExecutor;
private Response activeResponse;
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/cycle/BaseRequestHandlerStackTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/cycle/BaseRequestHandlerStackTest.java?rev=1070600&r1=1070599&r2=1070600&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/cycle/BaseRequestHandlerStackTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/cycle/BaseRequestHandlerStackTest.java Mon Feb 14 18:25:49 2011
@@ -20,7 +20,6 @@ import junit.framework.TestCase;
import org.apache.wicket.request.IRequestCycle;
import org.apache.wicket.request.IRequestHandler;
-import org.apache.wicket.request.IRequestHandlerExecutor;
import org.apache.wicket.request.Request;
import org.apache.wicket.request.RequestHandlerStack;
import org.apache.wicket.request.Response;
@@ -99,7 +98,7 @@ public abstract class BaseRequestHandler
}
- protected IRequestHandlerExecutor newStack(final IRequestCycle requestCycle)
+ protected RequestHandlerStack newStack(final IRequestCycle requestCycle)
{
return new RequestHandlerStack()
{
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/cycle/RequestHandlerStackTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/cycle/RequestHandlerStackTest.java?rev=1070600&r1=1070599&r2=1070600&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/cycle/RequestHandlerStackTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/cycle/RequestHandlerStackTest.java Mon Feb 14 18:25:49 2011
@@ -18,7 +18,7 @@ package org.apache.wicket.request.cycle;
import org.apache.wicket.request.IRequestCycle;
import org.apache.wicket.request.IRequestHandler;
-import org.apache.wicket.request.IRequestHandlerExecutor;
+import org.apache.wicket.request.RequestHandlerStack;
import org.apache.wicket.request.Response;
/**
@@ -67,7 +67,7 @@ public class RequestHandlerStackTest ext
final Response originalResponse = newResponse();
final IRequestCycle requestCycle = newRequestCycle(originalResponse);
- final IRequestHandlerExecutor stack = newStack(requestCycle);
+ final RequestHandlerStack stack = newStack(requestCycle);
final IRequestHandler handler3 = new IRequestHandler()
{
@@ -145,7 +145,7 @@ public class RequestHandlerStackTest ext
final Response originalResponse = newResponse();
final IRequestCycle requestCycle = newRequestCycle(originalResponse);
- final IRequestHandlerExecutor stack = newStack(requestCycle);
+ final RequestHandlerStack stack = newStack(requestCycle);
final IRequestHandler handler4 = new IRequestHandler()
@@ -243,7 +243,7 @@ public class RequestHandlerStackTest ext
final Response originalResponse = newResponse();
final IRequestCycle requestCycle = newRequestCycle(originalResponse);
- final IRequestHandlerExecutor stack = newStack(requestCycle);
+ final RequestHandlerStack stack = newStack(requestCycle);
final IRequestHandler handler4 = new IRequestHandler()
{
Modified: wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/RequestHandlerStack.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/RequestHandlerStack.java?rev=1070600&r1=1070599&r2=1070600&view=diff
==============================================================================
--- wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/RequestHandlerStack.java (original)
+++ wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/RequestHandlerStack.java Mon Feb 14 18:25:49 2011
@@ -30,7 +30,7 @@ import org.slf4j.LoggerFactory;
* @author Matej Knopp
* @author igor.vaynberg
*/
-public abstract class RequestHandlerStack implements IRequestHandlerExecutor
+public abstract class RequestHandlerStack
{
private static final Logger log = LoggerFactory.getLogger(RequestHandlerStack.class);