[jira] [Commented] (KAFKA-4092) retention.bytes should not be allowed to be less than segment.bytes

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446586#comment-15446586 ] 

ASF GitHub Bot commented on KAFKA-4092:
---------------------------------------

GitHub user cotedm opened a pull request:

    https://github.com/apache/kafka/pull/1796

    KAFKA-4092: retention.bytes should not be allowed to be less than segment.bytes

    adding a LogConfig value validator.  @gwenshap or @junrao would you mind taking a look?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cotedm/kafka retentionbytesvalidation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1796.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1796
    
----
commit 9312611cb6b92bf17984bf6a499206634526db38
Author: Dustin Cote <du...@confluent.io>
Date:   2016-08-29T18:01:01Z

    add a LogConfig value validator

----


> retention.bytes should not be allowed to be less than segment.bytes
> -------------------------------------------------------------------
>
>                 Key: KAFKA-4092
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4092
>             Project: Kafka
>          Issue Type: Improvement
>          Components: log
>            Reporter: Dustin Cote
>            Assignee: Dustin Cote
>            Priority: Minor
>
> Right now retention.bytes can be as small as the user wants but it doesn't really get acted on for the active segment if retention.bytes is smaller than segment.bytes.  We shouldn't allow retention.bytes to be less than segment.bytes and validate that at startup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)