You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Shuai Lin <li...@gmail.com> on 2016/02/08 18:09:27 UTC

Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-3775
    https://issues.apache.org/jira/browse/MESOS-3775


Repository: mesos


Description
-------

Speeded up MasterAllocatorTest.SlaveLost test.


Diffs
-----

  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 

Diff: https://reviews.apache.org/r/43329/diff/


Testing
-------

```
[----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAlloca
torProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter> >
[ RUN      ] MasterAllocatorTest/0.SlaveLost
[       OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
[----------] 1 test from MasterAllocatorTest/0 (369 ms total)

[----------] 1 test from MasterAllocatorTest/1, where TypeParam = mesos::internal::tests::Module<mesos::master::allocator::Allocator, (mesos::internal::tests::ModuleID)6>
[ RUN      ] MasterAllocatorTest/1.SlaveLost
[       OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
[----------] 1 test from MasterAllocatorTest/1 (120 ms total)
```


Thanks,

Shuai Lin


Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/#review118269
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43329]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 5:09 p.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43329/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 5:09 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3775
>     https://issues.apache.org/jira/browse/MESOS-3775
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speeded up MasterAllocatorTest.SlaveLost test.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
> 
> Diff: https://reviews.apache.org/r/43329/diff/
> 
> 
> Testing
> -------
> 
> ```
> [----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAlloca
> torProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter> >
> [ RUN      ] MasterAllocatorTest/0.SlaveLost
> [       OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
> [----------] 1 test from MasterAllocatorTest/0 (369 ms total)
> 
> [----------] 1 test from MasterAllocatorTest/1, where TypeParam = mesos::internal::tests::Module<mesos::master::allocator::Allocator, (mesos::internal::tests::ModuleID)6>
> [ RUN      ] MasterAllocatorTest/1.SlaveLost
> [       OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
> [----------] 1 test from MasterAllocatorTest/1 (120 ms total)
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>