[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7198: AWS: Check commit status after failed commit if AWS client performed retries

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #7198:
URL: https://github.com/apache/iceberg/pull/7198#discussion_r1151191961


##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -88,6 +91,32 @@ private static AwsClientFactory loadClientFactory(String impl, Map<String, Strin
     return factory;
   }
 
+  /**
+   * Metrics are the only reliable way provided by the AWS SDK to determine if an API call was
+   * retried. Not for public use.
+   */
+  public static class InternalRetryDetector implements MetricPublisher {

Review Comment:
   nit: for non-public classes, we should mark it as package protected or private



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org