You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/03 09:30:15 UTC

[GitHub] [tinkerpop] FlorianHockmann commented on a diff in pull request #1671: TINKERPOP-2749: Gremlin Javascript, Gremlint Windows build error fixes

FlorianHockmann commented on code in PR #1671:
URL: https://github.com/apache/tinkerpop/pull/1671#discussion_r888781587


##########
gremlin-javascript/src/main/javascript/gremlin-javascript/.eslintrc.js:
##########
@@ -31,9 +31,9 @@ module.exports = {
   extends: ['eslint:recommended', 'prettier'],
   plugins: ['prettier'],
   rules: {
-    'prettier/prettier': ['error'],

Review Comment:
   The changes in this file allow line endings to be `CRLF`, right? Is that really necessary? I guess we'd prefer if only Unix style line endings were committed, but maybe I'm missing something here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org