[GitHub] [dolphinscheduler] HomminLee commented on issue #14805: [Bug] [API] Modify deleted task will write twice version log

["HomminLee (via GitHub)" <gi...@apache.org>]

HomminLee commented on issue #14805:
URL: https://github.com/apache/dolphinscheduler/issues/14805#issuecomment-1694587482

   @jieguangzhou Hi, I noticed that there is some extra code in the `dev` branch.
    
   ```
   List<TaskDefinitionLog> newInsertTaskDefinitionLogs = newTaskDefinitionLogs.stream()
                   .filter(taskDefinitionLog -> !updateTaskDefinitionLogs.contains(taskDefinitionLog))
                   .collect(Collectors.toList());
   if (CollectionUtils.isNotEmpty(newInsertTaskDefinitionLogs)) {
       insertResult = taskDefinitionLogMapper.batchInsert(newInsertTaskDefinitionLogs);w
   }
   ```
   
   These code can fix this issue, and it's from pr #13103. This pr can be merge into branch 3.1.x?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org