You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "nabarunnag (GitHub)" <gi...@apache.org> on 2018/11/09 19:35:36 UTC
[GitHub] [geode] nabarunnag opened pull request #2827: GEODE-6028:
Remove checks that are not necessary.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2827 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] nabarunnag closed pull request #2827: GEODE-6028:
Remove checks that are not necessary.
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
[ pull request closed by nabarunnag ]
[ Full content available at: https://github.com/apache/geode/pull/2827 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] nabarunnag commented on issue #2827: GEODE-6028:
Remove checks that are not necessary.
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
@mcmellawatt Bruce also had the same question with an earlier similar PR. I generally add .diff at the end of the PR hyperlink (https://github.com/apache/geode/pull/2827.diff) and copy the page and in intelliJ I do the "apply patch from clipboard". Doing that you will be able easily see why the checks are unnecessary. It helps to look at PRs when it is tough to analyze it from the github webpage.
[ Full content available at: https://github.com/apache/geode/pull/2827 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org