You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/01/23 12:13:01 UTC

[GitHub] WillemJiang commented on a change in pull request #122: SCB-239 omega stateless

WillemJiang commented on a change in pull request #122: SCB-239 omega stateless
URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r163224863
 
 

 ##########
 File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/EventScanner.java
 ##########
 @@ -64,10 +66,12 @@ public void run() {
   private void pollEvents() {
     scheduler.scheduleWithFixedDelay(
         () -> {
+          abortTimeoutEvent();
           saveUncompensatedEventsToCommands();
           compensate();
           updateCompensatedCommands();
-          deleteDuplicateSagaEndedEvents();
+          deleteDuplicateEvents();
 
 Review comment:
   Why do you have the duplicated events ?  The scheduler work should be done without any interruption, what if the delete work is finished  but update transaction status work is failed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services