You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "progval (via GitHub)" <gi...@apache.org> on 2023/07/04 19:15:47 UTC

[GitHub] [orc] progval opened a new pull request, #1560: Mark `Int128::getHighBits()` and `Int128::getLowBits()` as `const`

progval opened a new pull request, #1560:
URL: https://github.com/apache/orc/pull/1560

   ### What changes were proposed in this pull request?
   
   These two accessors do not mutate the state, so they can be tagged as `const` to indicate this into callers.
   
   
   ### Why are the changes needed?
   
   Same motivation as #1558: I am writing a Rust binding, and the methods not being `const` give me extra constraints.
   
   
   ### How was this patch tested?
   
   `make test` passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac closed pull request #1560: ORC-1461: Mark `Int128::getHighBits()` and `Int128::getLowBits()` as `const`

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac closed pull request #1560: ORC-1461: Mark `Int128::getHighBits()` and `Int128::getLowBits()` as `const`
URL: https://github.com/apache/orc/pull/1560


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] progval commented on pull request #1560: ORC-1461: Mark `Int128::getHighBits()` and `Int128::getLowBits()` as `const`

Posted by "progval (via GitHub)" <gi...@apache.org>.
progval commented on PR #1560:
URL: https://github.com/apache/orc/pull/1560#issuecomment-1623446031

   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac commented on pull request #1560: Mark `Int128::getHighBits()` and `Int128::getLowBits()` as `const`

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1560:
URL: https://github.com/apache/orc/pull/1560#issuecomment-1622976450

   Thanks for submitting a PR! Could you please create a JIRA issue (https://issues.apache.org/jira/projects/ORC/issues/) for this? 
   
   If you need to create an account, please refer to https://selfserve.apache.org/jira-account.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac commented on pull request #1560: ORC-1461: Mark `Int128::getHighBits()` and `Int128::getLowBits()` as `const`

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1560:
URL: https://github.com/apache/orc/pull/1560#issuecomment-1623702024

   Thank you! @progval 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org