You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/04 12:34:39 UTC
[GitHub] [incubator-yunikorn-k8shim] 9501sam opened a new pull request #377: [YUNIKORN-1102] shim context getTask error is ignored
9501sam opened a new pull request #377:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/377
### What is this PR for?
modify context.getTask() and provide more detail about the reason of error:
* conversion error
* task not found error
and add unit test TestGetTask() for context.getTask()
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1102
### How should this be tested?
using ```make test``` command
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] 9501sam commented on a change in pull request #377: [YUNIKORN-1102] shim context getTask error is ignored
Posted by GitBox <gi...@apache.org>.
9501sam commented on a change in pull request #377:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/377#discussion_r821293919
##########
File path: pkg/cache/context.go
##########
@@ -700,17 +700,24 @@ func (ctx *Context) RemoveTask(appID, taskID string) error {
return fmt.Errorf("application %s is not found in the context", appID)
}
-func (ctx *Context) getTask(appID string, taskID string) (*Task, error) {
+func (ctx *Context) getTask(appID string, taskID string) *Task {
ctx.lock.RLock()
defer ctx.lock.RUnlock()
- if app, ok := ctx.applications[appID]; ok {
+ if app := ctx.GetApplication(appID); app != nil {
Review comment:
OK, that is really more clean, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #377: [YUNIKORN-1102] shim context getTask error is ignored
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #377:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #377: [YUNIKORN-1102] shim context getTask error is ignored
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/377#issuecomment-1059514596
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#377](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (acd7993) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/5e9b99733d36bbbd0c79a8baff34a0c0a8c87f10?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e9b997) will **decrease** coverage by `0.00%`.
> The diff coverage is `66.66%`.
> :exclamation: Current head acd7993 differs from pull request most recent head 2edd9aa. Consider uploading reports for the commit 2edd9aa to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
- Coverage 64.87% 64.87% -0.01%
==========================================
Files 41 41
Lines 6255 6257 +2
==========================================
+ Hits 4058 4059 +1
- Misses 2042 2043 +1
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `42.91% <66.66%> (+0.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5e9b997...2edd9aa](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #377: [YUNIKORN-1102] shim context getTask error is ignored
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/377#issuecomment-1059514596
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#377](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2edd9aa) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/5e9b99733d36bbbd0c79a8baff34a0c0a8c87f10?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e9b997) will **increase** coverage by `0.00%`.
> The diff coverage is `64.70%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 64.87% 64.88%
=======================================
Files 41 41
Lines 6255 6262 +7
=======================================
+ Hits 4058 4063 +5
- Misses 2042 2044 +2
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `43.18% <64.70%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5e9b997...2edd9aa](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #377: [YUNIKORN-1102] shim context getTask error is ignored
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/377#issuecomment-1059514596
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#377](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2edd9aa) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/5e9b99733d36bbbd0c79a8baff34a0c0a8c87f10?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e9b997) will **increase** coverage by `0.00%`.
> The diff coverage is `64.70%`.
> :exclamation: Current head 2edd9aa differs from pull request most recent head 0f55e3f. Consider uploading reports for the commit 0f55e3f to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 64.87% 64.88%
=======================================
Files 41 41
Lines 6255 6262 +7
=======================================
+ Hits 4058 4063 +5
- Misses 2042 2044 +2
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `43.18% <64.70%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5e9b997...0f55e3f](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #377: [YUNIKORN-1102] shim context getTask error is ignored
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/377#issuecomment-1059514596
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#377](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (acd7993) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/5e9b99733d36bbbd0c79a8baff34a0c0a8c87f10?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e9b997) will **decrease** coverage by `0.00%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
- Coverage 64.87% 64.87% -0.01%
==========================================
Files 41 41
Lines 6255 6257 +2
==========================================
+ Hits 4058 4059 +1
- Misses 2042 2043 +1
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `42.91% <66.66%> (+0.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5e9b997...acd7993](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #377: [YUNIKORN-1102] shim context getTask error is ignored
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #377:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/377#discussion_r821250941
##########
File path: pkg/cache/context.go
##########
@@ -700,17 +700,24 @@ func (ctx *Context) RemoveTask(appID, taskID string) error {
return fmt.Errorf("application %s is not found in the context", appID)
}
-func (ctx *Context) getTask(appID string, taskID string) (*Task, error) {
+func (ctx *Context) getTask(appID string, taskID string) *Task {
ctx.lock.RLock()
defer ctx.lock.RUnlock()
- if app, ok := ctx.applications[appID]; ok {
+ if app := ctx.GetApplication(appID); app != nil {
Review comment:
Looking at what we log in case of an issue I think we have a flow issue. If the task conversion fails we log 3 things: conversion failed, task not found and app not found. Really confusing. Go coding guidelines also state to prefer to return early and do not indent the correct case, indent the error handling
That would get a better user experience would be to just log the most specific message.
```
app := ctx.GetApplication(appID)
if app == nil {
log.Logger().....
return nil
}
managedTask, err := app.GetTask(taskID)
if err != nil {
log.Logger().....
return nil
}
task, valid := managedTask.(*Task)
if !valid {
log.Logger().....
return nil
}
return task
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] 9501sam commented on pull request #377: [YUNIKORN-1102] shim context getTask error is ignored
Posted by GitBox <gi...@apache.org>.
9501sam commented on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/377#issuecomment-1059719689
I think the conversion of ```managedTask``` would be always success.
Should I remove the conversion check ?
like:
```go
func (ctx *Context) getTask(appID string, taskID string) (*Task, error) {
ctx.lock.RLock()
defer ctx.lock.RUnlock()
if app := ctx.GetApplication(appID); app != nil {
if managedTask, err := app.GetTask(taskID); err == nil {
return task, nil
}
return nil, fmt.Errorf("task %s is not found in application %s", taskID, appID)
}
return nil, fmt.Errorf("application %s is not found in context", appID)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] 9501sam commented on pull request #377: [YUNIKORN-1102] shim context getTask error is ignored
Posted by GitBox <gi...@apache.org>.
9501sam commented on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/377#issuecomment-1060252894
OK, I understand !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #377: [YUNIKORN-1102] shim context getTask error is ignored
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/377#issuecomment-1059514596
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#377](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f55e3f) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/5e9b99733d36bbbd0c79a8baff34a0c0a8c87f10?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e9b997) will **decrease** coverage by `0.00%`.
> The diff coverage is `65.38%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
- Coverage 64.87% 64.87% -0.01%
==========================================
Files 41 41
Lines 6255 6269 +14
==========================================
+ Hits 4058 4067 +9
- Misses 2042 2046 +4
- Partials 155 156 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `43.31% <65.38%> (+0.42%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5e9b997...0f55e3f](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/377?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org