You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/24 09:50:21 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request #14447: [Broker] Optimize ``RawReader#create`` when use ``Compactor``
mattisonchao opened a new pull request #14447:
URL: https://github.com/apache/pulsar/pull/14447
### Motivation
Optimize ``RawReader#create`` when using ``Compactor`` to avoid calling more seek requests to change the position.
### Modifications
- Add config ``consumerConfiguration.setSubscriptionInitialPosition(SubscriptionInitialPosition.Earliest);`` to ``RawReaderImp``
- Remove ``x.seekAsync(MessageId.earliest)`` when create ``RawReader``.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14447: [Broker] Optimize RawReader#create when using Compactor
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14447:
URL: https://github.com/apache/pulsar/pull/14447#issuecomment-1081374885
This one is fixing the bug of reader leak
```
WARN org.apache.pulsar.broker.service.ServerCnx - [/10.124.5.91:36950][CompactorSubscription{topic=persistent://public/default/__transaction_buffer_snapshot, name=__compaction}] Failed to reset subscription: org.apache.pulsar.broker.service.BrokerServiceException$SubscriptionInvalidCursorPosition: unable to persist position for cursor reset 10909:-1
```
If the reader seeking encounter the above exception, the reader will never be closed, and the compaction task will be stuck. Only restarting the broker can recover from this state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #14447: [Broker] Optimize RawReader#create when using Compactor
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #14447:
URL: https://github.com/apache/pulsar/pull/14447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org