[GitHub] [incubator-openwhisk] rabbah commented on a change in pull request #4328: Set API key annotation for a WskConsole test

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #4328: Set API key annotation for a WskConsole test
URL: https://github.com/apache/incubator-openwhisk/pull/4328#discussion_r263895079
 
 

 ##########
 File path: tests/src/test/scala/system/basic/WskConsoleTests.scala
 ##########
 @@ -88,7 +90,10 @@ abstract class WskConsoleTests extends TestHelpers with WskTestHelpers {
   it should "show repeated activations" in withAssetCleaner(wskprops) { (wp, assetHelper) =>
     val name = withTimestamp("countdown")
     assetHelper.withCleaner(wsk.action, name) { (action, _) =>
-      action.create(name, Some(TestUtils.getTestActionFilename("countdown.js")))
+      action.create(
+        name,
+        Some(TestUtils.getTestActionFilename("countdown.js")),
+        annotations = Map(WhiskAction.provideApiKeyAnnotationName -> JsBoolean(true)))
 
 Review comment:
   i think this test suite should move entirely to the CLI IMO. 
   that said, why does the test not fail here already 😲 ?
   
   i agree the annotation should be present for countdown to work since it does an action invoke.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services