[jira] [Commented] (NIFI-5466) Improve efficiency of RingBufferEventRepository

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571991#comment-16571991 ] 

ASF GitHub Bot commented on NIFI-5466:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/2939

    NIFI-5466: Keep a running total of stats for each component. Refactor…

    …ed FlowFileEvent and repository in order to provide more efficient storage of objects on Java heap by allowing the same 'EMPTY' object to be reused
    
     - Refactored VolatileComponentStatusRepository to avoid holding on to ProcessorStatus objects, etc, and only keep what they need
     - Updated VolatileComponentStatusRepository to ensure that we are efficiently storing metrics for processors, etc. that are not running
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-5466

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2939.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2939
    
----
commit 278f2ae1c395219a584debf252d8491fe507ad17
Author: Mark Payne <ma...@...>
Date:   2018-08-02T18:17:36Z

    NIFI-5466: Keep a running total of stats for each component. Refactored FlowFileEvent and repository in order to provide more efficient storage of objects on Java heap by allowing the same 'EMPTY' object to be reused
     - Refactored VolatileComponentStatusRepository to avoid holding on to ProcessorStatus objects, etc, and only keep what they need
     - Updated VolatileComponentStatusRepository to ensure that we are efficiently storing metrics for processors, etc. that are not running

----


> Improve efficiency of RingBufferEventRepository
> -----------------------------------------------
>
>                 Key: NIFI-5466
>                 URL: https://issues.apache.org/jira/browse/NIFI-5466
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>             Fix For: 1.8.0
>
>
> The implementation of the FlowFileEventRepository (i.e., the RingBufferEventRepository) is implemented in such a way that 300 buckets are kept for each component. Each bucket holds a set of 16+ stats (bytes read, bytes written, flowfiles in, flowfiles out, etc. as well as counters)
> Each time that a user refreshes stats, we calculate the 5-minute window for each component by iterating over all 300 buckets, then summing together the values of the stats. So, for every 1,000 processors, we have 1000 * 300 * 16 = 4.8 MM calculations being performed each time that the user refreshes.
> We can improve this significantly. To do this, we can keep a 'running tally' for each stat. Every time that we update a bucket in the FlowFileEventRepository, we should similarly update the running tally. Each time that we 'replace' a bucket in the FlowFileEventRepository, we should subtract from the running tally the values in the bucket, in addition to adding in the new value. This would result in amortizing the cost of calculation over the 5-minute period and means that every time that we get the processor stats we could do so by simply performing a 'get' operation without any calculations.
> But wait, there's more! The EventSumValue class has an {{add(FlowFileEvent)}} method. If the EventSumValue were to simply keep a boolean value indicating whether or not it was empty, then when adding to an empty bucket we could avoid the calculations all together, and when replacing an empty bucket we could avoid the calculation against the running tally as well.
> Similarly, in the VolatileComponentStatusRepository, when we perform a 'capture' we should detect any 'empty' stats objects and use a single static instance for this, which would significantly reduce the amount of heap that is used to store metrics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)