You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/05 10:08:12 UTC

[GitHub] [flink] aljoscha commented on a change in pull request #10431: [FLINK-15067][table] Pass configuration to the underlying ExecutionEnvironment from TableEnvironment

aljoscha commented on a change in pull request #10431:  [FLINK-15067][table] Pass configuration to the underlying ExecutionEnvironment from TableEnvironment
URL: https://github.com/apache/flink/pull/10431#discussion_r354213160
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java
 ##########
 @@ -757,7 +757,7 @@ else if (configOption.hasFallbackKeys()) {
 	}
 
 	@Override
-	public <T> WritableConfig set(ConfigOption<T> option, T value) {
+	public <T> Configuration set(ConfigOption<T> option, T value) {
 
 Review comment:
   This is necessary as a workaround to make the builder pattern with `addConfiguration()` work, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services