You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "张铎(Duo Zhang)" <pa...@gmail.com> on 2022/03/04 16:24:49 UTC
[VOTE] The first release condidate for hbase-thirdparty 4.1.0 is available for download
Please vote on this Apache hbase thirdparty release candidate,
hbase-thirdparty-4.1.0RC0
The VOTE will remain open for at least 72 hours.
[ ] +1 Release this package as Apache hbase thirdparty 4.1.0
[ ] -1 Do not release this package because ...
The tag to be voted on is 4.1.0RC0:
https://github.com/apache/hbase-thirdparty/tree/4.1.0RC0
This tag currently points to git reference
c120582f161149e0c8a6b2ec134b5bf22d859a21
The release files, including signatures, digests, as well as CHANGES.md
and RELEASENOTES.md included in this RC can be found at:
https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.1.0RC0/
Maven artifacts are available in a staging repository at:
https://repository.apache.org/content/repositories/orgapachehbase-1482/
Artifacts were signed with the 9AD2AE49 key which can be found in:
https://downloads.apache.org/hbase/KEYS
To learn more about Apache hbase thirdparty, please see
http://hbase.apache.org/
Thanks,
Your HBase Release Manager
Re: [VOTE] The first release condidate for hbase-thirdparty 4.1.0 is available for download
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
With 3 binding +1s, and no -1, the vote passes.
Thanks all for voting. Let me finish the release.
张铎(Duo Zhang) <pa...@gmail.com> 于2022年3月11日周五 10:08写道：
> Thanks Nick.
>
> Here is my own +1, I've already tested it through a github PR and all
> seems fine.
>
> Nick Dimiduk <nd...@apache.org> 于2022年3月11日周五 02:35写道：
>
>> I agree, we can add the enforcement in a later release.
>>
>> With a little tweaking, the hbase-vote.sh script from the main repo worked
>> out.
>>
>> +1
>>
>> * Signature: ok
>> * Checksum : ok
>> * Rat check (1.8.0_292): ok
>> - mvn clean apache-rat:check
>> * Built from source (1.8.0_292): ok
>> - mvn clean install -DskipTests
>> * Unit tests pass (1.8.0_292): ok
>> - mvn clean package -Dsurefire.rerunFailingTestsCount=3
>>
>> On Thu, Mar 10, 2022 at 1:15 AM 张铎(Duo Zhang) <pa...@gmail.com>
>> wrote:
>>
>> > Technically it should be possible to build with jdk11, we need to use
>> > source 8 and target 8 and expose the jdk.unsupported.
>> >
>> > But in this way, we can not make sure that the artifacts we produced can
>> > work with jdk8, especially that the hbase-shaded-protobuf stuff, so I
>> agree
>> > with you that we'd better add some enforcer rule. Since this does not
>> > effect the release artifacts, I think this can be done as a follow on
>> > issue?
>> >
>> > Thanks.
>> >
>> > Nick Dimiduk <nd...@apache.org> 于2022年3月8日周二 22:14写道：
>> >
>> > > So we explicitly only support building hbase-thirdparty with JDK8?
>> Should
>> > > we add some enforcer checks to assure this?
>> > >
>> > > With JDK11 (11.0.11), I see:
>> > >
>> > > [ERROR]
>> > >
>> > >
>> >
>> /Users/ndimiduk/tmp/hbase-thirdparty-4.1.0RC0/hbase-thirdparty-4.1.0RC0/hbase-thirdparty-4.1.0/hbase-unsafe/src/main/java/org/apache/hadoop/hbase/unsafe/HBaseUnsafeInternal.java:[259,18]
>> > > cannot find symbol
>> > > symbol: method
>> > >
>> > >
>> >
>> defineClass(java.lang.String,byte[],int,int,java.lang.ClassLoader,java.security.ProtectionDomain)
>> > > location: variable UNSAFE of type sun.misc.Unsafe
>> > >
>> > >
>> > >
>> > > On Tue, Mar 8, 2022 at 2:17 PM 张铎(Duo Zhang) <pa...@gmail.com>
>> > > wrote:
>> > >
>> > > > https://github.com/apache/hbase/pull/4164
>> > > >
>> > > > After upgrading jackson to 2.13.1, the UT looks good now.
>> > > >
>> > > > So general, with hbase-thirdparty 4.1.0 in place, we could use
>> > --release
>> > > 8
>> > > > when compiling with java 11! which is a good news that we could
>> move up
>> > > the
>> > > > jdk11+ on HBase 3.x but still maintain the jdk8 compatibility for
>> the
>> > > > binary releases.
>> > > >
>> > > > We still need more votes to send this release out.
>> > > >
>> > > > Thanks.
>> > > >
>> > > > Andrew Purtell <an...@gmail.com> 于2022年3月6日周日 09:12写道：
>> > > >
>> > > > > I had to revert Jackson from 2.13.1 back to 2.12.4 in one of our
>> > > internal
>> > > > > repos for this same problem. We noticed CNFEs in REST unit tests.
>> It
>> > > > didn’t
>> > > > > occur to me it might be a problem in open source, because the
>> > internal
>> > > > tree
>> > > > > is a 1.x version.
>> > > > >
>> > > > > We should figure out what additional dependencies must be
>> explicitly
>> > > > added
>> > > > > now or the next time Jackson has a security issue we will have to
>> > deal
>> > > > with
>> > > > > it then. I can look at this Monday if you don’t have time before
>> > then.
>> > > > >
>> > > > > I agree we should bring all of Jackson in to thirdparty.
>> > > > >
>> > > > > > On Mar 5, 2022, at 4:34 PM, 张铎 <pa...@gmail.com> wrote:
>> > > > > >
>> > > > > > OK, this is because we have upgraded jackson in
>> hbase-thirdparty
>> > to
>> > > > > 2.13.1
>> > > > > > while in the main repo we are still on 2.10.1.
>> > > > > >
>> > > > > > I've upgraded the dependency in the main repo to 2.13.1 too.
>> > > > > >
>> > > > > > Let's see if it works. And maybe we should shade all jackson
>> > related
>> > > > jars
>> > > > > > in hbase-thirdparty in the future?
>> > > > > >
>> > > > > > 张铎(Duo Zhang) <pa...@gmail.com> 于2022年3月6日周日 08:20写道：
>> > > > > >
>> > > > > >> https://github.com/apache/hbase/pull/4164
>> > > > > >>
>> > > > > >> In this PR, all the UTs in rest fail with ClassNotFound.
>> > > > > >>
>> > > > > >> Seems we missed some classes when shading hbase-thirdparty.
>> > > > > >>
>> > > > > >> Will dig more.
>> > > > > >>
>> > > > > >> Andrew Purtell <ap...@apache.org> 于2022年3月5日周六 03:04写道：
>> > > > > >>
>> > > > > >>> +1 (binding)
>> > > > > >>>
>> > > > > >>> * Signature: ok
>> > > > > >>> * Checksum : ok
>> > > > > >>> * Rat check (1.8.0_322): ok
>> > > > > >>> - mvn clean apache-rat:check
>> > > > > >>> * Built from source (1.8.0_322): ok
>> > > > > >>> - mvn clean install -DskipTests
>> > > > > >>> * Unit tests for new hbase-unsafe module (1.8.0_322):
>> ok
>> > > > > >>> - ( cd hbase-unsafe && mvn clean install )
>> > > > > >>>
>> > > > > >>>
>> > > > > >>>
>> > > > > >>> On Fri, Mar 4, 2022 at 8:25 AM 张铎(Duo Zhang) <
>> > > palomino219@gmail.com>
>> > > > > >>> wrote:
>> > > > > >>>
>> > > > > >>>> Please vote on this Apache hbase thirdparty release
>> candidate,
>> > > > > >>>> hbase-thirdparty-4.1.0RC0
>> > > > > >>>>
>> > > > > >>>> The VOTE will remain open for at least 72 hours.
>> > > > > >>>>
>> > > > > >>>> [ ] +1 Release this package as Apache hbase thirdparty 4.1.0
>> > > > > >>>> [ ] -1 Do not release this package because ...
>> > > > > >>>>
>> > > > > >>>> The tag to be voted on is 4.1.0RC0:
>> > > > > >>>>
>> > > > > >>>> https://github.com/apache/hbase-thirdparty/tree/4.1.0RC0
>> > > > > >>>>
>> > > > > >>>> This tag currently points to git reference
>> > > > > >>>>
>> > > > > >>>> c120582f161149e0c8a6b2ec134b5bf22d859a21
>> > > > > >>>>
>> > > > > >>>> The release files, including signatures, digests, as well as
>> > > > > CHANGES.md
>> > > > > >>>> and RELEASENOTES.md included in this RC can be found at:
>> > > > > >>>>
>> > > > > >>>>
>> > > > > >>>
>> > > > >
>> > >
>> https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.1.0RC0/
>> > > > > >>>>
>> > > > > >>>> Maven artifacts are available in a staging repository at:
>> > > > > >>>>
>> > > > > >>>>
>> > > > > >>>
>> > > > >
>> > >
>> https://repository.apache.org/content/repositories/orgapachehbase-1482/
>> > > > > >>>>
>> > > > > >>>> Artifacts were signed with the 9AD2AE49 key which can be
>> found
>> > in:
>> > > > > >>>>
>> > > > > >>>> https://downloads.apache.org/hbase/KEYS
>> > > > > >>>>
>> > > > > >>>> To learn more about Apache hbase thirdparty, please see
>> > > > > >>>>
>> > > > > >>>> http://hbase.apache.org/
>> > > > > >>>>
>> > > > > >>>> Thanks,
>> > > > > >>>> Your HBase Release Manager
>> > > > > >>>>
>> > > > > >>>
>> > > > > >>>
>> > > > > >>> --
>> > > > > >>> Best regards,
>> > > > > >>> Andrew
>> > > > > >>>
>> > > > > >>> Unrest, ignorance distilled, nihilistic imbeciles -
>> > > > > >>> It's what we’ve earned
>> > > > > >>> Welcome, apocalypse, what’s taken you so long?
>> > > > > >>> Bring us the fitting end that we’ve been counting on
>> > > > > >>> - A23, Welcome, Apocalypse
>> > > > > >>>
>> > > > > >>
>> > > > >
>> > > >
>> > >
>> >
>>
>
Re: [VOTE] The first release condidate for hbase-thirdparty 4.1.0 is available for download
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
Thanks Nick.
Here is my own +1, I've already tested it through a github PR and all seems
fine.
Nick Dimiduk <nd...@apache.org> 于2022年3月11日周五 02:35写道：
> I agree, we can add the enforcement in a later release.
>
> With a little tweaking, the hbase-vote.sh script from the main repo worked
> out.
>
> +1
>
> * Signature: ok
> * Checksum : ok
> * Rat check (1.8.0_292): ok
> - mvn clean apache-rat:check
> * Built from source (1.8.0_292): ok
> - mvn clean install -DskipTests
> * Unit tests pass (1.8.0_292): ok
> - mvn clean package -Dsurefire.rerunFailingTestsCount=3
>
> On Thu, Mar 10, 2022 at 1:15 AM 张铎(Duo Zhang) <pa...@gmail.com>
> wrote:
>
> > Technically it should be possible to build with jdk11, we need to use
> > source 8 and target 8 and expose the jdk.unsupported.
> >
> > But in this way, we can not make sure that the artifacts we produced can
> > work with jdk8, especially that the hbase-shaded-protobuf stuff, so I
> agree
> > with you that we'd better add some enforcer rule. Since this does not
> > effect the release artifacts, I think this can be done as a follow on
> > issue?
> >
> > Thanks.
> >
> > Nick Dimiduk <nd...@apache.org> 于2022年3月8日周二 22:14写道：
> >
> > > So we explicitly only support building hbase-thirdparty with JDK8?
> Should
> > > we add some enforcer checks to assure this?
> > >
> > > With JDK11 (11.0.11), I see:
> > >
> > > [ERROR]
> > >
> > >
> >
> /Users/ndimiduk/tmp/hbase-thirdparty-4.1.0RC0/hbase-thirdparty-4.1.0RC0/hbase-thirdparty-4.1.0/hbase-unsafe/src/main/java/org/apache/hadoop/hbase/unsafe/HBaseUnsafeInternal.java:[259,18]
> > > cannot find symbol
> > > symbol: method
> > >
> > >
> >
> defineClass(java.lang.String,byte[],int,int,java.lang.ClassLoader,java.security.ProtectionDomain)
> > > location: variable UNSAFE of type sun.misc.Unsafe
> > >
> > >
> > >
> > > On Tue, Mar 8, 2022 at 2:17 PM 张铎(Duo Zhang) <pa...@gmail.com>
> > > wrote:
> > >
> > > > https://github.com/apache/hbase/pull/4164
> > > >
> > > > After upgrading jackson to 2.13.1, the UT looks good now.
> > > >
> > > > So general, with hbase-thirdparty 4.1.0 in place, we could use
> > --release
> > > 8
> > > > when compiling with java 11! which is a good news that we could move
> up
> > > the
> > > > jdk11+ on HBase 3.x but still maintain the jdk8 compatibility for the
> > > > binary releases.
> > > >
> > > > We still need more votes to send this release out.
> > > >
> > > > Thanks.
> > > >
> > > > Andrew Purtell <an...@gmail.com> 于2022年3月6日周日 09:12写道：
> > > >
> > > > > I had to revert Jackson from 2.13.1 back to 2.12.4 in one of our
> > > internal
> > > > > repos for this same problem. We noticed CNFEs in REST unit tests.
> It
> > > > didn’t
> > > > > occur to me it might be a problem in open source, because the
> > internal
> > > > tree
> > > > > is a 1.x version.
> > > > >
> > > > > We should figure out what additional dependencies must be
> explicitly
> > > > added
> > > > > now or the next time Jackson has a security issue we will have to
> > deal
> > > > with
> > > > > it then. I can look at this Monday if you don’t have time before
> > then.
> > > > >
> > > > > I agree we should bring all of Jackson in to thirdparty.
> > > > >
> > > > > > On Mar 5, 2022, at 4:34 PM, 张铎 <pa...@gmail.com> wrote:
> > > > > >
> > > > > > OK, this is because we have upgraded jackson in hbase-thirdparty
> > to
> > > > > 2.13.1
> > > > > > while in the main repo we are still on 2.10.1.
> > > > > >
> > > > > > I've upgraded the dependency in the main repo to 2.13.1 too.
> > > > > >
> > > > > > Let's see if it works. And maybe we should shade all jackson
> > related
> > > > jars
> > > > > > in hbase-thirdparty in the future?
> > > > > >
> > > > > > 张铎(Duo Zhang) <pa...@gmail.com> 于2022年3月6日周日 08:20写道：
> > > > > >
> > > > > >> https://github.com/apache/hbase/pull/4164
> > > > > >>
> > > > > >> In this PR, all the UTs in rest fail with ClassNotFound.
> > > > > >>
> > > > > >> Seems we missed some classes when shading hbase-thirdparty.
> > > > > >>
> > > > > >> Will dig more.
> > > > > >>
> > > > > >> Andrew Purtell <ap...@apache.org> 于2022年3月5日周六 03:04写道：
> > > > > >>
> > > > > >>> +1 (binding)
> > > > > >>>
> > > > > >>> * Signature: ok
> > > > > >>> * Checksum : ok
> > > > > >>> * Rat check (1.8.0_322): ok
> > > > > >>> - mvn clean apache-rat:check
> > > > > >>> * Built from source (1.8.0_322): ok
> > > > > >>> - mvn clean install -DskipTests
> > > > > >>> * Unit tests for new hbase-unsafe module (1.8.0_322): ok
> > > > > >>> - ( cd hbase-unsafe && mvn clean install )
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>> On Fri, Mar 4, 2022 at 8:25 AM 张铎(Duo Zhang) <
> > > palomino219@gmail.com>
> > > > > >>> wrote:
> > > > > >>>
> > > > > >>>> Please vote on this Apache hbase thirdparty release candidate,
> > > > > >>>> hbase-thirdparty-4.1.0RC0
> > > > > >>>>
> > > > > >>>> The VOTE will remain open for at least 72 hours.
> > > > > >>>>
> > > > > >>>> [ ] +1 Release this package as Apache hbase thirdparty 4.1.0
> > > > > >>>> [ ] -1 Do not release this package because ...
> > > > > >>>>
> > > > > >>>> The tag to be voted on is 4.1.0RC0:
> > > > > >>>>
> > > > > >>>> https://github.com/apache/hbase-thirdparty/tree/4.1.0RC0
> > > > > >>>>
> > > > > >>>> This tag currently points to git reference
> > > > > >>>>
> > > > > >>>> c120582f161149e0c8a6b2ec134b5bf22d859a21
> > > > > >>>>
> > > > > >>>> The release files, including signatures, digests, as well as
> > > > > CHANGES.md
> > > > > >>>> and RELEASENOTES.md included in this RC can be found at:
> > > > > >>>>
> > > > > >>>>
> > > > > >>>
> > > > >
> > >
> https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.1.0RC0/
> > > > > >>>>
> > > > > >>>> Maven artifacts are available in a staging repository at:
> > > > > >>>>
> > > > > >>>>
> > > > > >>>
> > > > >
> > >
> https://repository.apache.org/content/repositories/orgapachehbase-1482/
> > > > > >>>>
> > > > > >>>> Artifacts were signed with the 9AD2AE49 key which can be found
> > in:
> > > > > >>>>
> > > > > >>>> https://downloads.apache.org/hbase/KEYS
> > > > > >>>>
> > > > > >>>> To learn more about Apache hbase thirdparty, please see
> > > > > >>>>
> > > > > >>>> http://hbase.apache.org/
> > > > > >>>>
> > > > > >>>> Thanks,
> > > > > >>>> Your HBase Release Manager
> > > > > >>>>
> > > > > >>>
> > > > > >>>
> > > > > >>> --
> > > > > >>> Best regards,
> > > > > >>> Andrew
> > > > > >>>
> > > > > >>> Unrest, ignorance distilled, nihilistic imbeciles -
> > > > > >>> It's what we’ve earned
> > > > > >>> Welcome, apocalypse, what’s taken you so long?
> > > > > >>> Bring us the fitting end that we’ve been counting on
> > > > > >>> - A23, Welcome, Apocalypse
> > > > > >>>
> > > > > >>
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] The first release condidate for hbase-thirdparty 4.1.0 is available for download
Posted by Nick Dimiduk <nd...@apache.org>.
I agree, we can add the enforcement in a later release.
With a little tweaking, the hbase-vote.sh script from the main repo worked
out.
+1
* Signature: ok
* Checksum : ok
* Rat check (1.8.0_292): ok
- mvn clean apache-rat:check
* Built from source (1.8.0_292): ok
- mvn clean install -DskipTests
* Unit tests pass (1.8.0_292): ok
- mvn clean package -Dsurefire.rerunFailingTestsCount=3
On Thu, Mar 10, 2022 at 1:15 AM 张铎(Duo Zhang) <pa...@gmail.com> wrote:
> Technically it should be possible to build with jdk11, we need to use
> source 8 and target 8 and expose the jdk.unsupported.
>
> But in this way, we can not make sure that the artifacts we produced can
> work with jdk8, especially that the hbase-shaded-protobuf stuff, so I agree
> with you that we'd better add some enforcer rule. Since this does not
> effect the release artifacts, I think this can be done as a follow on
> issue?
>
> Thanks.
>
> Nick Dimiduk <nd...@apache.org> 于2022年3月8日周二 22:14写道：
>
> > So we explicitly only support building hbase-thirdparty with JDK8? Should
> > we add some enforcer checks to assure this?
> >
> > With JDK11 (11.0.11), I see:
> >
> > [ERROR]
> >
> >
> /Users/ndimiduk/tmp/hbase-thirdparty-4.1.0RC0/hbase-thirdparty-4.1.0RC0/hbase-thirdparty-4.1.0/hbase-unsafe/src/main/java/org/apache/hadoop/hbase/unsafe/HBaseUnsafeInternal.java:[259,18]
> > cannot find symbol
> > symbol: method
> >
> >
> defineClass(java.lang.String,byte[],int,int,java.lang.ClassLoader,java.security.ProtectionDomain)
> > location: variable UNSAFE of type sun.misc.Unsafe
> >
> >
> >
> > On Tue, Mar 8, 2022 at 2:17 PM 张铎(Duo Zhang) <pa...@gmail.com>
> > wrote:
> >
> > > https://github.com/apache/hbase/pull/4164
> > >
> > > After upgrading jackson to 2.13.1, the UT looks good now.
> > >
> > > So general, with hbase-thirdparty 4.1.0 in place, we could use
> --release
> > 8
> > > when compiling with java 11! which is a good news that we could move up
> > the
> > > jdk11+ on HBase 3.x but still maintain the jdk8 compatibility for the
> > > binary releases.
> > >
> > > We still need more votes to send this release out.
> > >
> > > Thanks.
> > >
> > > Andrew Purtell <an...@gmail.com> 于2022年3月6日周日 09:12写道：
> > >
> > > > I had to revert Jackson from 2.13.1 back to 2.12.4 in one of our
> > internal
> > > > repos for this same problem. We noticed CNFEs in REST unit tests. It
> > > didn’t
> > > > occur to me it might be a problem in open source, because the
> internal
> > > tree
> > > > is a 1.x version.
> > > >
> > > > We should figure out what additional dependencies must be explicitly
> > > added
> > > > now or the next time Jackson has a security issue we will have to
> deal
> > > with
> > > > it then. I can look at this Monday if you don’t have time before
> then.
> > > >
> > > > I agree we should bring all of Jackson in to thirdparty.
> > > >
> > > > > On Mar 5, 2022, at 4:34 PM, 张铎 <pa...@gmail.com> wrote:
> > > > >
> > > > > OK, this is because we have upgraded jackson in hbase-thirdparty
> to
> > > > 2.13.1
> > > > > while in the main repo we are still on 2.10.1.
> > > > >
> > > > > I've upgraded the dependency in the main repo to 2.13.1 too.
> > > > >
> > > > > Let's see if it works. And maybe we should shade all jackson
> related
> > > jars
> > > > > in hbase-thirdparty in the future?
> > > > >
> > > > > 张铎(Duo Zhang) <pa...@gmail.com> 于2022年3月6日周日 08:20写道：
> > > > >
> > > > >> https://github.com/apache/hbase/pull/4164
> > > > >>
> > > > >> In this PR, all the UTs in rest fail with ClassNotFound.
> > > > >>
> > > > >> Seems we missed some classes when shading hbase-thirdparty.
> > > > >>
> > > > >> Will dig more.
> > > > >>
> > > > >> Andrew Purtell <ap...@apache.org> 于2022年3月5日周六 03:04写道：
> > > > >>
> > > > >>> +1 (binding)
> > > > >>>
> > > > >>> * Signature: ok
> > > > >>> * Checksum : ok
> > > > >>> * Rat check (1.8.0_322): ok
> > > > >>> - mvn clean apache-rat:check
> > > > >>> * Built from source (1.8.0_322): ok
> > > > >>> - mvn clean install -DskipTests
> > > > >>> * Unit tests for new hbase-unsafe module (1.8.0_322): ok
> > > > >>> - ( cd hbase-unsafe && mvn clean install )
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>> On Fri, Mar 4, 2022 at 8:25 AM 张铎(Duo Zhang) <
> > palomino219@gmail.com>
> > > > >>> wrote:
> > > > >>>
> > > > >>>> Please vote on this Apache hbase thirdparty release candidate,
> > > > >>>> hbase-thirdparty-4.1.0RC0
> > > > >>>>
> > > > >>>> The VOTE will remain open for at least 72 hours.
> > > > >>>>
> > > > >>>> [ ] +1 Release this package as Apache hbase thirdparty 4.1.0
> > > > >>>> [ ] -1 Do not release this package because ...
> > > > >>>>
> > > > >>>> The tag to be voted on is 4.1.0RC0:
> > > > >>>>
> > > > >>>> https://github.com/apache/hbase-thirdparty/tree/4.1.0RC0
> > > > >>>>
> > > > >>>> This tag currently points to git reference
> > > > >>>>
> > > > >>>> c120582f161149e0c8a6b2ec134b5bf22d859a21
> > > > >>>>
> > > > >>>> The release files, including signatures, digests, as well as
> > > > CHANGES.md
> > > > >>>> and RELEASENOTES.md included in this RC can be found at:
> > > > >>>>
> > > > >>>>
> > > > >>>
> > > >
> > https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.1.0RC0/
> > > > >>>>
> > > > >>>> Maven artifacts are available in a staging repository at:
> > > > >>>>
> > > > >>>>
> > > > >>>
> > > >
> > https://repository.apache.org/content/repositories/orgapachehbase-1482/
> > > > >>>>
> > > > >>>> Artifacts were signed with the 9AD2AE49 key which can be found
> in:
> > > > >>>>
> > > > >>>> https://downloads.apache.org/hbase/KEYS
> > > > >>>>
> > > > >>>> To learn more about Apache hbase thirdparty, please see
> > > > >>>>
> > > > >>>> http://hbase.apache.org/
> > > > >>>>
> > > > >>>> Thanks,
> > > > >>>> Your HBase Release Manager
> > > > >>>>
> > > > >>>
> > > > >>>
> > > > >>> --
> > > > >>> Best regards,
> > > > >>> Andrew
> > > > >>>
> > > > >>> Unrest, ignorance distilled, nihilistic imbeciles -
> > > > >>> It's what we’ve earned
> > > > >>> Welcome, apocalypse, what’s taken you so long?
> > > > >>> Bring us the fitting end that we’ve been counting on
> > > > >>> - A23, Welcome, Apocalypse
> > > > >>>
> > > > >>
> > > >
> > >
> >
>
Re: [VOTE] The first release condidate for hbase-thirdparty 4.1.0 is available for download
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
Technically it should be possible to build with jdk11, we need to use
source 8 and target 8 and expose the jdk.unsupported.
But in this way, we can not make sure that the artifacts we produced can
work with jdk8, especially that the hbase-shaded-protobuf stuff, so I agree
with you that we'd better add some enforcer rule. Since this does not
effect the release artifacts, I think this can be done as a follow on issue?
Thanks.
Nick Dimiduk <nd...@apache.org> 于2022年3月8日周二 22:14写道：
> So we explicitly only support building hbase-thirdparty with JDK8? Should
> we add some enforcer checks to assure this?
>
> With JDK11 (11.0.11), I see:
>
> [ERROR]
>
> /Users/ndimiduk/tmp/hbase-thirdparty-4.1.0RC0/hbase-thirdparty-4.1.0RC0/hbase-thirdparty-4.1.0/hbase-unsafe/src/main/java/org/apache/hadoop/hbase/unsafe/HBaseUnsafeInternal.java:[259,18]
> cannot find symbol
> symbol: method
>
> defineClass(java.lang.String,byte[],int,int,java.lang.ClassLoader,java.security.ProtectionDomain)
> location: variable UNSAFE of type sun.misc.Unsafe
>
>
>
> On Tue, Mar 8, 2022 at 2:17 PM 张铎(Duo Zhang) <pa...@gmail.com>
> wrote:
>
> > https://github.com/apache/hbase/pull/4164
> >
> > After upgrading jackson to 2.13.1, the UT looks good now.
> >
> > So general, with hbase-thirdparty 4.1.0 in place, we could use --release
> 8
> > when compiling with java 11! which is a good news that we could move up
> the
> > jdk11+ on HBase 3.x but still maintain the jdk8 compatibility for the
> > binary releases.
> >
> > We still need more votes to send this release out.
> >
> > Thanks.
> >
> > Andrew Purtell <an...@gmail.com> 于2022年3月6日周日 09:12写道：
> >
> > > I had to revert Jackson from 2.13.1 back to 2.12.4 in one of our
> internal
> > > repos for this same problem. We noticed CNFEs in REST unit tests. It
> > didn’t
> > > occur to me it might be a problem in open source, because the internal
> > tree
> > > is a 1.x version.
> > >
> > > We should figure out what additional dependencies must be explicitly
> > added
> > > now or the next time Jackson has a security issue we will have to deal
> > with
> > > it then. I can look at this Monday if you don’t have time before then.
> > >
> > > I agree we should bring all of Jackson in to thirdparty.
> > >
> > > > On Mar 5, 2022, at 4:34 PM, 张铎 <pa...@gmail.com> wrote:
> > > >
> > > > OK, this is because we have upgraded jackson in hbase-thirdparty to
> > > 2.13.1
> > > > while in the main repo we are still on 2.10.1.
> > > >
> > > > I've upgraded the dependency in the main repo to 2.13.1 too.
> > > >
> > > > Let's see if it works. And maybe we should shade all jackson related
> > jars
> > > > in hbase-thirdparty in the future?
> > > >
> > > > 张铎(Duo Zhang) <pa...@gmail.com> 于2022年3月6日周日 08:20写道：
> > > >
> > > >> https://github.com/apache/hbase/pull/4164
> > > >>
> > > >> In this PR, all the UTs in rest fail with ClassNotFound.
> > > >>
> > > >> Seems we missed some classes when shading hbase-thirdparty.
> > > >>
> > > >> Will dig more.
> > > >>
> > > >> Andrew Purtell <ap...@apache.org> 于2022年3月5日周六 03:04写道：
> > > >>
> > > >>> +1 (binding)
> > > >>>
> > > >>> * Signature: ok
> > > >>> * Checksum : ok
> > > >>> * Rat check (1.8.0_322): ok
> > > >>> - mvn clean apache-rat:check
> > > >>> * Built from source (1.8.0_322): ok
> > > >>> - mvn clean install -DskipTests
> > > >>> * Unit tests for new hbase-unsafe module (1.8.0_322): ok
> > > >>> - ( cd hbase-unsafe && mvn clean install )
> > > >>>
> > > >>>
> > > >>>
> > > >>> On Fri, Mar 4, 2022 at 8:25 AM 张铎(Duo Zhang) <
> palomino219@gmail.com>
> > > >>> wrote:
> > > >>>
> > > >>>> Please vote on this Apache hbase thirdparty release candidate,
> > > >>>> hbase-thirdparty-4.1.0RC0
> > > >>>>
> > > >>>> The VOTE will remain open for at least 72 hours.
> > > >>>>
> > > >>>> [ ] +1 Release this package as Apache hbase thirdparty 4.1.0
> > > >>>> [ ] -1 Do not release this package because ...
> > > >>>>
> > > >>>> The tag to be voted on is 4.1.0RC0:
> > > >>>>
> > > >>>> https://github.com/apache/hbase-thirdparty/tree/4.1.0RC0
> > > >>>>
> > > >>>> This tag currently points to git reference
> > > >>>>
> > > >>>> c120582f161149e0c8a6b2ec134b5bf22d859a21
> > > >>>>
> > > >>>> The release files, including signatures, digests, as well as
> > > CHANGES.md
> > > >>>> and RELEASENOTES.md included in this RC can be found at:
> > > >>>>
> > > >>>>
> > > >>>
> > >
> https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.1.0RC0/
> > > >>>>
> > > >>>> Maven artifacts are available in a staging repository at:
> > > >>>>
> > > >>>>
> > > >>>
> > >
> https://repository.apache.org/content/repositories/orgapachehbase-1482/
> > > >>>>
> > > >>>> Artifacts were signed with the 9AD2AE49 key which can be found in:
> > > >>>>
> > > >>>> https://downloads.apache.org/hbase/KEYS
> > > >>>>
> > > >>>> To learn more about Apache hbase thirdparty, please see
> > > >>>>
> > > >>>> http://hbase.apache.org/
> > > >>>>
> > > >>>> Thanks,
> > > >>>> Your HBase Release Manager
> > > >>>>
> > > >>>
> > > >>>
> > > >>> --
> > > >>> Best regards,
> > > >>> Andrew
> > > >>>
> > > >>> Unrest, ignorance distilled, nihilistic imbeciles -
> > > >>> It's what we’ve earned
> > > >>> Welcome, apocalypse, what’s taken you so long?
> > > >>> Bring us the fitting end that we’ve been counting on
> > > >>> - A23, Welcome, Apocalypse
> > > >>>
> > > >>
> > >
> >
>
Re: [VOTE] The first release condidate for hbase-thirdparty 4.1.0 is available for download
Posted by Nick Dimiduk <nd...@apache.org>.
So we explicitly only support building hbase-thirdparty with JDK8? Should
we add some enforcer checks to assure this?
With JDK11 (11.0.11), I see:
[ERROR]
/Users/ndimiduk/tmp/hbase-thirdparty-4.1.0RC0/hbase-thirdparty-4.1.0RC0/hbase-thirdparty-4.1.0/hbase-unsafe/src/main/java/org/apache/hadoop/hbase/unsafe/HBaseUnsafeInternal.java:[259,18]
cannot find symbol
symbol: method
defineClass(java.lang.String,byte[],int,int,java.lang.ClassLoader,java.security.ProtectionDomain)
location: variable UNSAFE of type sun.misc.Unsafe
On Tue, Mar 8, 2022 at 2:17 PM 张铎(Duo Zhang) <pa...@gmail.com> wrote:
> https://github.com/apache/hbase/pull/4164
>
> After upgrading jackson to 2.13.1, the UT looks good now.
>
> So general, with hbase-thirdparty 4.1.0 in place, we could use --release 8
> when compiling with java 11! which is a good news that we could move up the
> jdk11+ on HBase 3.x but still maintain the jdk8 compatibility for the
> binary releases.
>
> We still need more votes to send this release out.
>
> Thanks.
>
> Andrew Purtell <an...@gmail.com> 于2022年3月6日周日 09:12写道：
>
> > I had to revert Jackson from 2.13.1 back to 2.12.4 in one of our internal
> > repos for this same problem. We noticed CNFEs in REST unit tests. It
> didn’t
> > occur to me it might be a problem in open source, because the internal
> tree
> > is a 1.x version.
> >
> > We should figure out what additional dependencies must be explicitly
> added
> > now or the next time Jackson has a security issue we will have to deal
> with
> > it then. I can look at this Monday if you don’t have time before then.
> >
> > I agree we should bring all of Jackson in to thirdparty.
> >
> > > On Mar 5, 2022, at 4:34 PM, 张铎 <pa...@gmail.com> wrote:
> > >
> > > OK, this is because we have upgraded jackson in hbase-thirdparty to
> > 2.13.1
> > > while in the main repo we are still on 2.10.1.
> > >
> > > I've upgraded the dependency in the main repo to 2.13.1 too.
> > >
> > > Let's see if it works. And maybe we should shade all jackson related
> jars
> > > in hbase-thirdparty in the future?
> > >
> > > 张铎(Duo Zhang) <pa...@gmail.com> 于2022年3月6日周日 08:20写道：
> > >
> > >> https://github.com/apache/hbase/pull/4164
> > >>
> > >> In this PR, all the UTs in rest fail with ClassNotFound.
> > >>
> > >> Seems we missed some classes when shading hbase-thirdparty.
> > >>
> > >> Will dig more.
> > >>
> > >> Andrew Purtell <ap...@apache.org> 于2022年3月5日周六 03:04写道：
> > >>
> > >>> +1 (binding)
> > >>>
> > >>> * Signature: ok
> > >>> * Checksum : ok
> > >>> * Rat check (1.8.0_322): ok
> > >>> - mvn clean apache-rat:check
> > >>> * Built from source (1.8.0_322): ok
> > >>> - mvn clean install -DskipTests
> > >>> * Unit tests for new hbase-unsafe module (1.8.0_322): ok
> > >>> - ( cd hbase-unsafe && mvn clean install )
> > >>>
> > >>>
> > >>>
> > >>> On Fri, Mar 4, 2022 at 8:25 AM 张铎(Duo Zhang) <pa...@gmail.com>
> > >>> wrote:
> > >>>
> > >>>> Please vote on this Apache hbase thirdparty release candidate,
> > >>>> hbase-thirdparty-4.1.0RC0
> > >>>>
> > >>>> The VOTE will remain open for at least 72 hours.
> > >>>>
> > >>>> [ ] +1 Release this package as Apache hbase thirdparty 4.1.0
> > >>>> [ ] -1 Do not release this package because ...
> > >>>>
> > >>>> The tag to be voted on is 4.1.0RC0:
> > >>>>
> > >>>> https://github.com/apache/hbase-thirdparty/tree/4.1.0RC0
> > >>>>
> > >>>> This tag currently points to git reference
> > >>>>
> > >>>> c120582f161149e0c8a6b2ec134b5bf22d859a21
> > >>>>
> > >>>> The release files, including signatures, digests, as well as
> > CHANGES.md
> > >>>> and RELEASENOTES.md included in this RC can be found at:
> > >>>>
> > >>>>
> > >>>
> > https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.1.0RC0/
> > >>>>
> > >>>> Maven artifacts are available in a staging repository at:
> > >>>>
> > >>>>
> > >>>
> > https://repository.apache.org/content/repositories/orgapachehbase-1482/
> > >>>>
> > >>>> Artifacts were signed with the 9AD2AE49 key which can be found in:
> > >>>>
> > >>>> https://downloads.apache.org/hbase/KEYS
> > >>>>
> > >>>> To learn more about Apache hbase thirdparty, please see
> > >>>>
> > >>>> http://hbase.apache.org/
> > >>>>
> > >>>> Thanks,
> > >>>> Your HBase Release Manager
> > >>>>
> > >>>
> > >>>
> > >>> --
> > >>> Best regards,
> > >>> Andrew
> > >>>
> > >>> Unrest, ignorance distilled, nihilistic imbeciles -
> > >>> It's what we’ve earned
> > >>> Welcome, apocalypse, what’s taken you so long?
> > >>> Bring us the fitting end that we’ve been counting on
> > >>> - A23, Welcome, Apocalypse
> > >>>
> > >>
> >
>
Re: [VOTE] The first release condidate for hbase-thirdparty 4.1.0 is available for download
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
https://github.com/apache/hbase/pull/4164
After upgrading jackson to 2.13.1, the UT looks good now.
So general, with hbase-thirdparty 4.1.0 in place, we could use --release 8
when compiling with java 11! which is a good news that we could move up the
jdk11+ on HBase 3.x but still maintain the jdk8 compatibility for the
binary releases.
We still need more votes to send this release out.
Thanks.
Andrew Purtell <an...@gmail.com> 于2022年3月6日周日 09:12写道：
> I had to revert Jackson from 2.13.1 back to 2.12.4 in one of our internal
> repos for this same problem. We noticed CNFEs in REST unit tests. It didn’t
> occur to me it might be a problem in open source, because the internal tree
> is a 1.x version.
>
> We should figure out what additional dependencies must be explicitly added
> now or the next time Jackson has a security issue we will have to deal with
> it then. I can look at this Monday if you don’t have time before then.
>
> I agree we should bring all of Jackson in to thirdparty.
>
> > On Mar 5, 2022, at 4:34 PM, 张铎 <pa...@gmail.com> wrote:
> >
> > OK, this is because we have upgraded jackson in hbase-thirdparty to
> 2.13.1
> > while in the main repo we are still on 2.10.1.
> >
> > I've upgraded the dependency in the main repo to 2.13.1 too.
> >
> > Let's see if it works. And maybe we should shade all jackson related jars
> > in hbase-thirdparty in the future?
> >
> > 张铎(Duo Zhang) <pa...@gmail.com> 于2022年3月6日周日 08:20写道：
> >
> >> https://github.com/apache/hbase/pull/4164
> >>
> >> In this PR, all the UTs in rest fail with ClassNotFound.
> >>
> >> Seems we missed some classes when shading hbase-thirdparty.
> >>
> >> Will dig more.
> >>
> >> Andrew Purtell <ap...@apache.org> 于2022年3月5日周六 03:04写道：
> >>
> >>> +1 (binding)
> >>>
> >>> * Signature: ok
> >>> * Checksum : ok
> >>> * Rat check (1.8.0_322): ok
> >>> - mvn clean apache-rat:check
> >>> * Built from source (1.8.0_322): ok
> >>> - mvn clean install -DskipTests
> >>> * Unit tests for new hbase-unsafe module (1.8.0_322): ok
> >>> - ( cd hbase-unsafe && mvn clean install )
> >>>
> >>>
> >>>
> >>> On Fri, Mar 4, 2022 at 8:25 AM 张铎(Duo Zhang) <pa...@gmail.com>
> >>> wrote:
> >>>
> >>>> Please vote on this Apache hbase thirdparty release candidate,
> >>>> hbase-thirdparty-4.1.0RC0
> >>>>
> >>>> The VOTE will remain open for at least 72 hours.
> >>>>
> >>>> [ ] +1 Release this package as Apache hbase thirdparty 4.1.0
> >>>> [ ] -1 Do not release this package because ...
> >>>>
> >>>> The tag to be voted on is 4.1.0RC0:
> >>>>
> >>>> https://github.com/apache/hbase-thirdparty/tree/4.1.0RC0
> >>>>
> >>>> This tag currently points to git reference
> >>>>
> >>>> c120582f161149e0c8a6b2ec134b5bf22d859a21
> >>>>
> >>>> The release files, including signatures, digests, as well as
> CHANGES.md
> >>>> and RELEASENOTES.md included in this RC can be found at:
> >>>>
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.1.0RC0/
> >>>>
> >>>> Maven artifacts are available in a staging repository at:
> >>>>
> >>>>
> >>>
> https://repository.apache.org/content/repositories/orgapachehbase-1482/
> >>>>
> >>>> Artifacts were signed with the 9AD2AE49 key which can be found in:
> >>>>
> >>>> https://downloads.apache.org/hbase/KEYS
> >>>>
> >>>> To learn more about Apache hbase thirdparty, please see
> >>>>
> >>>> http://hbase.apache.org/
> >>>>
> >>>> Thanks,
> >>>> Your HBase Release Manager
> >>>>
> >>>
> >>>
> >>> --
> >>> Best regards,
> >>> Andrew
> >>>
> >>> Unrest, ignorance distilled, nihilistic imbeciles -
> >>> It's what we’ve earned
> >>> Welcome, apocalypse, what’s taken you so long?
> >>> Bring us the fitting end that we’ve been counting on
> >>> - A23, Welcome, Apocalypse
> >>>
> >>
>
Re: [VOTE] The first release condidate for hbase-thirdparty 4.1.0 is available for download
Posted by Andrew Purtell <an...@gmail.com>.
I had to revert Jackson from 2.13.1 back to 2.12.4 in one of our internal repos for this same problem. We noticed CNFEs in REST unit tests. It didn’t occur to me it might be a problem in open source, because the internal tree is a 1.x version.
We should figure out what additional dependencies must be explicitly added now or the next time Jackson has a security issue we will have to deal with it then. I can look at this Monday if you don’t have time before then.
I agree we should bring all of Jackson in to thirdparty.
> On Mar 5, 2022, at 4:34 PM, 张铎 <pa...@gmail.com> wrote:
>
> OK, this is because we have upgraded jackson in hbase-thirdparty to 2.13.1
> while in the main repo we are still on 2.10.1.
>
> I've upgraded the dependency in the main repo to 2.13.1 too.
>
> Let's see if it works. And maybe we should shade all jackson related jars
> in hbase-thirdparty in the future?
>
> 张铎(Duo Zhang) <pa...@gmail.com> 于2022年3月6日周日 08:20写道：
>
>> https://github.com/apache/hbase/pull/4164
>>
>> In this PR, all the UTs in rest fail with ClassNotFound.
>>
>> Seems we missed some classes when shading hbase-thirdparty.
>>
>> Will dig more.
>>
>> Andrew Purtell <ap...@apache.org> 于2022年3月5日周六 03:04写道：
>>
>>> +1 (binding)
>>>
>>> * Signature: ok
>>> * Checksum : ok
>>> * Rat check (1.8.0_322): ok
>>> - mvn clean apache-rat:check
>>> * Built from source (1.8.0_322): ok
>>> - mvn clean install -DskipTests
>>> * Unit tests for new hbase-unsafe module (1.8.0_322): ok
>>> - ( cd hbase-unsafe && mvn clean install )
>>>
>>>
>>>
>>> On Fri, Mar 4, 2022 at 8:25 AM 张铎(Duo Zhang) <pa...@gmail.com>
>>> wrote:
>>>
>>>> Please vote on this Apache hbase thirdparty release candidate,
>>>> hbase-thirdparty-4.1.0RC0
>>>>
>>>> The VOTE will remain open for at least 72 hours.
>>>>
>>>> [ ] +1 Release this package as Apache hbase thirdparty 4.1.0
>>>> [ ] -1 Do not release this package because ...
>>>>
>>>> The tag to be voted on is 4.1.0RC0:
>>>>
>>>> https://github.com/apache/hbase-thirdparty/tree/4.1.0RC0
>>>>
>>>> This tag currently points to git reference
>>>>
>>>> c120582f161149e0c8a6b2ec134b5bf22d859a21
>>>>
>>>> The release files, including signatures, digests, as well as CHANGES.md
>>>> and RELEASENOTES.md included in this RC can be found at:
>>>>
>>>>
>>> https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.1.0RC0/
>>>>
>>>> Maven artifacts are available in a staging repository at:
>>>>
>>>>
>>> https://repository.apache.org/content/repositories/orgapachehbase-1482/
>>>>
>>>> Artifacts were signed with the 9AD2AE49 key which can be found in:
>>>>
>>>> https://downloads.apache.org/hbase/KEYS
>>>>
>>>> To learn more about Apache hbase thirdparty, please see
>>>>
>>>> http://hbase.apache.org/
>>>>
>>>> Thanks,
>>>> Your HBase Release Manager
>>>>
>>>
>>>
>>> --
>>> Best regards,
>>> Andrew
>>>
>>> Unrest, ignorance distilled, nihilistic imbeciles -
>>> It's what we’ve earned
>>> Welcome, apocalypse, what’s taken you so long?
>>> Bring us the fitting end that we’ve been counting on
>>> - A23, Welcome, Apocalypse
>>>
>>
Re: [VOTE] The first release condidate for hbase-thirdparty 4.1.0 is available for download
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
OK, this is because we have upgraded jackson in hbase-thirdparty to 2.13.1
while in the main repo we are still on 2.10.1.
I've upgraded the dependency in the main repo to 2.13.1 too.
Let's see if it works. And maybe we should shade all jackson related jars
in hbase-thirdparty in the future?
张铎(Duo Zhang) <pa...@gmail.com> 于2022年3月6日周日 08:20写道：
> https://github.com/apache/hbase/pull/4164
>
> In this PR, all the UTs in rest fail with ClassNotFound.
>
> Seems we missed some classes when shading hbase-thirdparty.
>
> Will dig more.
>
> Andrew Purtell <ap...@apache.org> 于2022年3月5日周六 03:04写道：
>
>> +1 (binding)
>>
>> * Signature: ok
>> * Checksum : ok
>> * Rat check (1.8.0_322): ok
>> - mvn clean apache-rat:check
>> * Built from source (1.8.0_322): ok
>> - mvn clean install -DskipTests
>> * Unit tests for new hbase-unsafe module (1.8.0_322): ok
>> - ( cd hbase-unsafe && mvn clean install )
>>
>>
>>
>> On Fri, Mar 4, 2022 at 8:25 AM 张铎(Duo Zhang) <pa...@gmail.com>
>> wrote:
>>
>> > Please vote on this Apache hbase thirdparty release candidate,
>> > hbase-thirdparty-4.1.0RC0
>> >
>> > The VOTE will remain open for at least 72 hours.
>> >
>> > [ ] +1 Release this package as Apache hbase thirdparty 4.1.0
>> > [ ] -1 Do not release this package because ...
>> >
>> > The tag to be voted on is 4.1.0RC0:
>> >
>> > https://github.com/apache/hbase-thirdparty/tree/4.1.0RC0
>> >
>> > This tag currently points to git reference
>> >
>> > c120582f161149e0c8a6b2ec134b5bf22d859a21
>> >
>> > The release files, including signatures, digests, as well as CHANGES.md
>> > and RELEASENOTES.md included in this RC can be found at:
>> >
>> >
>> https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.1.0RC0/
>> >
>> > Maven artifacts are available in a staging repository at:
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachehbase-1482/
>> >
>> > Artifacts were signed with the 9AD2AE49 key which can be found in:
>> >
>> > https://downloads.apache.org/hbase/KEYS
>> >
>> > To learn more about Apache hbase thirdparty, please see
>> >
>> > http://hbase.apache.org/
>> >
>> > Thanks,
>> > Your HBase Release Manager
>> >
>>
>>
>> --
>> Best regards,
>> Andrew
>>
>> Unrest, ignorance distilled, nihilistic imbeciles -
>> It's what we’ve earned
>> Welcome, apocalypse, what’s taken you so long?
>> Bring us the fitting end that we’ve been counting on
>> - A23, Welcome, Apocalypse
>>
>
Re: [VOTE] The first release condidate for hbase-thirdparty 4.1.0 is available for download
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
https://github.com/apache/hbase/pull/4164
In this PR, all the UTs in rest fail with ClassNotFound.
Seems we missed some classes when shading hbase-thirdparty.
Will dig more.
Andrew Purtell <ap...@apache.org> 于2022年3月5日周六 03:04写道：
> +1 (binding)
>
> * Signature: ok
> * Checksum : ok
> * Rat check (1.8.0_322): ok
> - mvn clean apache-rat:check
> * Built from source (1.8.0_322): ok
> - mvn clean install -DskipTests
> * Unit tests for new hbase-unsafe module (1.8.0_322): ok
> - ( cd hbase-unsafe && mvn clean install )
>
>
>
> On Fri, Mar 4, 2022 at 8:25 AM 张铎(Duo Zhang) <pa...@gmail.com>
> wrote:
>
> > Please vote on this Apache hbase thirdparty release candidate,
> > hbase-thirdparty-4.1.0RC0
> >
> > The VOTE will remain open for at least 72 hours.
> >
> > [ ] +1 Release this package as Apache hbase thirdparty 4.1.0
> > [ ] -1 Do not release this package because ...
> >
> > The tag to be voted on is 4.1.0RC0:
> >
> > https://github.com/apache/hbase-thirdparty/tree/4.1.0RC0
> >
> > This tag currently points to git reference
> >
> > c120582f161149e0c8a6b2ec134b5bf22d859a21
> >
> > The release files, including signatures, digests, as well as CHANGES.md
> > and RELEASENOTES.md included in this RC can be found at:
> >
> >
> https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.1.0RC0/
> >
> > Maven artifacts are available in a staging repository at:
> >
> >
> https://repository.apache.org/content/repositories/orgapachehbase-1482/
> >
> > Artifacts were signed with the 9AD2AE49 key which can be found in:
> >
> > https://downloads.apache.org/hbase/KEYS
> >
> > To learn more about Apache hbase thirdparty, please see
> >
> > http://hbase.apache.org/
> >
> > Thanks,
> > Your HBase Release Manager
> >
>
>
> --
> Best regards,
> Andrew
>
> Unrest, ignorance distilled, nihilistic imbeciles -
> It's what we’ve earned
> Welcome, apocalypse, what’s taken you so long?
> Bring us the fitting end that we’ve been counting on
> - A23, Welcome, Apocalypse
>
Re: [VOTE] The first release condidate for hbase-thirdparty 4.1.0 is available for download
Posted by Andrew Purtell <ap...@apache.org>.
+1 (binding)
* Signature: ok
* Checksum : ok
* Rat check (1.8.0_322): ok
- mvn clean apache-rat:check
* Built from source (1.8.0_322): ok
- mvn clean install -DskipTests
* Unit tests for new hbase-unsafe module (1.8.0_322): ok
- ( cd hbase-unsafe && mvn clean install )
On Fri, Mar 4, 2022 at 8:25 AM 张铎(Duo Zhang) <pa...@gmail.com> wrote:
> Please vote on this Apache hbase thirdparty release candidate,
> hbase-thirdparty-4.1.0RC0
>
> The VOTE will remain open for at least 72 hours.
>
> [ ] +1 Release this package as Apache hbase thirdparty 4.1.0
> [ ] -1 Do not release this package because ...
>
> The tag to be voted on is 4.1.0RC0:
>
> https://github.com/apache/hbase-thirdparty/tree/4.1.0RC0
>
> This tag currently points to git reference
>
> c120582f161149e0c8a6b2ec134b5bf22d859a21
>
> The release files, including signatures, digests, as well as CHANGES.md
> and RELEASENOTES.md included in this RC can be found at:
>
> https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.1.0RC0/
>
> Maven artifacts are available in a staging repository at:
>
> https://repository.apache.org/content/repositories/orgapachehbase-1482/
>
> Artifacts were signed with the 9AD2AE49 key which can be found in:
>
> https://downloads.apache.org/hbase/KEYS
>
> To learn more about Apache hbase thirdparty, please see
>
> http://hbase.apache.org/
>
> Thanks,
> Your HBase Release Manager
>
--
Best regards,
Andrew
Unrest, ignorance distilled, nihilistic imbeciles -
It's what we’ve earned
Welcome, apocalypse, what’s taken you so long?
Bring us the fitting end that we’ve been counting on
- A23, Welcome, Apocalypse