You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "ho-229 (via GitHub)" <gi...@apache.org> on 2024/08/06 17:24:35 UTC
[PR] feat(integrations/cloudfilter): introduce behavior tests [opendal]
ho-229 opened a new pull request, #4973:
URL: https://github.com/apache/opendal/pull/4973
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(integrations/cloudfilter): introduce behavior tests [opendal]
Posted by "ho-229 (via GitHub)" <gi...@apache.org>.
ho-229 commented on PR #4973:
URL: https://github.com/apache/opendal/pull/4973#issuecomment-2286108045
Fixed @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(integrations/cloudfilter): introduce behavior tests [opendal]
Posted by "ho-229 (via GitHub)" <gi...@apache.org>.
ho-229 commented on PR #4973:
URL: https://github.com/apache/opendal/pull/4973#issuecomment-2286007809
cc @Xuanwo , PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(integrations/cloudfilter): introduce behavior tests [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #4973:
URL: https://github.com/apache/opendal/pull/4973#discussion_r1712981672
##########
.github/scripts/test_behavior/plan.py:
##########
@@ -270,6 +286,20 @@ def generate_bin_cases(
return cases
+def generate_integration_cases(
Review Comment:
Maybe we don't need to touch here if cloudfilter only support fs now?
##########
.github/workflows/test_behavior_integration_cloudfilter.yml:
##########
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Behavior Test Integration CloudFilter
+
+on:
+ workflow_call:
+ inputs:
+ os:
+ required: true
+ type: string
+ cases:
+ required: true
+ type: string
+
+jobs:
+ test:
+ name: ${{ matrix.cases.service }} / ${{ matrix.cases.setup }}
+ runs-on: ${{ inputs.os }}
+ timeout-minutes: 10
+
+ strategy:
+ matrix:
+ cases: ${{ fromJson(inputs.cases) }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ with:
+ need-protoc: true
+ need-rocksdb: true
+ github-token: ${{ secrets.GITHUB_TOKEN }}
+
+ # TODO: 1password is only supported on linux
+ #
+ # Waiting for https://github.com/1Password/load-secrets-action/issues/46
+ - name: Setup 1Password Connect
+ if: runner.os == 'Linux'
+ uses: 1password/load-secrets-action/configure@v1
+ with:
+ connect-host: ${{ secrets.OP_CONNECT_HOST }}
+ connect-token: ${{ secrets.OP_CONNECT_TOKEN }}
+
+ - name: Test Integration CloudFilter
+ uses: ./.github/actions/test_behavior_integration_cloudfilter
Review Comment:
We can test directly here without altering the entire integration test system if Cloudflitler only supports fs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(integrations/cloudfilter): introduce behavior tests [opendal]
Posted by "ho-229 (via GitHub)" <gi...@apache.org>.
ho-229 commented on PR #4973:
URL: https://github.com/apache/opendal/pull/4973#issuecomment-2282751499
Hi @Xuanwo and @oowl , please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(integrations/cloudfilter): introduce behavior tests [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #4973:
URL: https://github.com/apache/opendal/pull/4973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(integrations/cloudfilter): introduce behavior tests [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #4973:
URL: https://github.com/apache/opendal/pull/4973#discussion_r1713006205
##########
.github/scripts/test_behavior/plan.py:
##########
Review Comment:
The same.
##########
.github/workflows/test_behavior.yml:
##########
@@ -145,3 +145,17 @@ jobs:
with:
os: ${{ matrix.os }}
cases: ${{ toJson(matrix.cases) }}
+
+ test_integration_cloudfilter:
Review Comment:
We don't need this anymore?
##########
.github/workflows/test_behavior_integration_cloudfilter.yml:
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Behavior Test Integration CloudFilter
+
+on:
+ workflow_call:
Review Comment:
We can use on `pull_request` instead.
##########
.github/scripts/test_behavior/test_plan.py:
##########
Review Comment:
Maybe we can also remove those changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(integrations/cloudfilter): introduce behavior tests [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #4973:
URL: https://github.com/apache/opendal/pull/4973#discussion_r1715148637
##########
.github/workflows/test_behavior_integration_cloudfilter.yml:
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Behavior Test Integration CloudFilter
+
+on:
+ push:
+ paths:
+ - "integrations/cloudfilter/**.rs"
+ - "integrations/cloudfilter/Cargo.toml"
+ - ".github/workflows/test_behavior_integration_cloudfilter.yml"
+ pull_request:
+ paths:
+ - "integrations/cloudfilter/**.rs"
+ - "integrations/cloudfilter/Cargo.toml"
+ - ".github/workflows/test_behavior_integration_cloudfilter.yml"
+
+jobs:
+ test:
+ name: fs / fixture_data
+ runs-on: windows-latest
+ timeout-minutes: 10
+
+ steps:
+ - uses: actions/checkout@v4
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ with:
+ need-protoc: true
+ need-rocksdb: true
+ github-token: ${{ secrets.GITHUB_TOKEN }}
Review Comment:
We don't need this.
##########
.github/workflows/test_behavior_integration_cloudfilter.yml:
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Behavior Test Integration CloudFilter
+
+on:
+ push:
+ paths:
+ - "integrations/cloudfilter/**.rs"
+ - "integrations/cloudfilter/Cargo.toml"
+ - ".github/workflows/test_behavior_integration_cloudfilter.yml"
+ pull_request:
+ paths:
+ - "integrations/cloudfilter/**.rs"
+ - "integrations/cloudfilter/Cargo.toml"
+ - ".github/workflows/test_behavior_integration_cloudfilter.yml"
+
+jobs:
+ test:
+ name: fs / fixture_data
+ runs-on: windows-latest
+ timeout-minutes: 10
+
+ steps:
+ - uses: actions/checkout@v4
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ with:
+ need-protoc: true
+ need-rocksdb: true
+ github-token: ${{ secrets.GITHUB_TOKEN }}
+
+ # TODO: 1password is only supported on linux
+ #
+ # Waiting for https://github.com/1Password/load-secrets-action/issues/46
+ - name: Setup 1Password Connect
+ if: runner.os == 'Linux'
+ uses: 1password/load-secrets-action/configure@v1
+ with:
+ connect-host: ${{ secrets.OP_CONNECT_HOST }}
+ connect-token: ${{ secrets.OP_CONNECT_TOKEN }}
Review Comment:
We don't need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(integrations/cloudfilter): introduce behavior tests [opendal]
Posted by "ho-229 (via GitHub)" <gi...@apache.org>.
ho-229 commented on PR #4973:
URL: https://github.com/apache/opendal/pull/4973#issuecomment-2282769149
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org