You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/09/16 06:11:50 UTC
[GitHub] [ratis] jiacheliu3 commented on a diff in pull request #733: RATIS-1709 Support specify ThreadGroup for Daemon threads
jiacheliu3 commented on code in PR #733:
URL: https://github.com/apache/ratis/pull/733#discussion_r972646944
##########
ratis-common/src/main/java/org/apache/ratis/util/Daemon.java:
##########
@@ -17,24 +17,59 @@
*/
package org.apache.ratis.util;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Objects;
+
public class Daemon extends Thread {
+ static final Logger LOG = LoggerFactory.getLogger(Daemon.class);
+ public static final Thread.UncaughtExceptionHandler LOG_EXCEPTION =
+ (t, e) -> LOG.error(t.getName() + " threw an uncaught exception", e);
Review Comment:
Sounds good. This has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org