You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/08/25 22:13:00 UTC

[jira] [Commented] (ARTEMIS-3956) Clean up use of RemotingConnection

    [ https://issues.apache.org/jira/browse/ARTEMIS-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585045#comment-17585045 ] 

ASF subversion and git services commented on ARTEMIS-3956:
----------------------------------------------------------

Commit a0f39a4b28545f4010e07d950c34fe9f1f228b68 in activemq-artemis's branch refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=a0f39a4b28 ]

ARTEMIS-3956 clean up use of RemotingConnection

org.apache.activemq.artemis.spi.core.protocol.RemotingConnection has a
number of implementations most notably an abstract version which
provides many methods shared among the implementations. The sharing
could be improved to eliminate duplicate code.

This commit eliminates more than 700 lines of unnecessary code.

There should be no semantic changes.


> Clean up use of RemotingConnection
> ----------------------------------
>
>                 Key: ARTEMIS-3956
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3956
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>
> {{org.apache.activemq.artemis.spi.core.protocol.RemotingConnection}} has a number of implementations most notably an {{abstract}} version which provides many methods shared among the implementations. The sharing could be improved to eliminate duplicate code.
> Also, the interface could provide a simple, noop default implementation to reduce duplicate code in _tests_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)