You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "summaryzb (via GitHub)" <gi...@apache.org> on 2023/10/08 13:18:10 UTC

[PR] improvement: Implement ShuffleDataIo [incubator-uniffle]

summaryzb opened a new pull request, #1226:
URL: https://github.com/apache/incubator-uniffle/pull/1226

   ### What changes were proposed in this pull request?
   Implement ShuffleDataIo
   
   ### Why are the changes needed?
   https://github.com/apache/incubator-uniffle/issues/802
   
   ### Does this PR introduce _any_ user-facing change?
   Yes. To use spark dynamicAllocation, user should set `spark.shuffle.sort.io.plugin.class` to `org.apache.spark.shuffle.RssShuffleDataIo`, otherwise spark3.5 will fail
   
   ### How was this patch tested?
   Integration test
   Manual test
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#802] feat(spark): Implement ShuffleDataIo [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1226:
URL: https://github.com/apache/incubator-uniffle/pull/1226


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] improvement: Implement ShuffleDataIo [incubator-uniffle]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1226:
URL: https://github.com/apache/incubator-uniffle/pull/1226#issuecomment-1752028465

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1226?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#1226](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1226?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (55ee6ef) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/fa6d1625c8426181f13c45a87607af4e31f49458?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fa6d162) will **decrease** coverage by `0.64%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1226      +/-   ##
   ============================================
   - Coverage     54.58%   53.94%   -0.64%     
   + Complexity     2613     2136     -477     
   ============================================
     Files           373      321      -52     
     Lines         20213    14608    -5605     
     Branches       1929     1363     -566     
   ============================================
   - Hits          11034     7881    -3153     
   + Misses         8515     6281    -2234     
   + Partials        664      446     -218     
   ```
   
   
   [see 56 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1226/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org