You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sgrebnov <gi...@git.apache.org> on 2014/06/20 15:08:08 UTC
[GitHub] cordova-lib pull request: CB-6976 Add support for Windows Universa...
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/39
CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1)
https://issues.apache.org/jira/browse/CB-6976
* Added new windows platform
* New platform can detect and correctly build both old Windows8 and new Windows project templates
* To have existing plugins working and for smooth transition added logic to re-use windows8 configuration settings (plugin.xml, config.xml).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib win81
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 7ed25a53a793a2af3ff3bc51799ef65fa302a643
Author: sgrebnov <v-...@microsoft.com>
Date: 2014-06-20T12:53:45Z
CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6976 Add support for Windows Universa...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/39#discussion_r14055726
--- Diff: cordova-lib/src/cordova/platforms.js ---
@@ -69,10 +69,17 @@ module.exports = {
},
'windows8':{
hostos : ['win32'],
- parser: './metadata/windows8_parser',
- url : 'https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git',
- version: '3.5.0',
- subdirectory: 'windows8'
+ parser: './metadata/windows_parser',
+ url : 'http://github.com/MSOpenTech/cordova-windows/archive/win81.tar.gz',
+ version: '3.6.0',
+ subdirectory: 'windows'
+ },
+ 'windows':{
+ hostos : ['win32'],
+ parser: './metadata/windows_parser',
+ url : 'http://github.com/MSOpenTech/cordova-windows/archive/win81.tar.gz',
--- End diff --
TODO: must be updated with correct url
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6976 Add support for Windows Universa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6976 Add support for Windows Universa...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/39#discussion_r14055725
--- Diff: cordova-lib/src/cordova/platforms.js ---
@@ -69,10 +69,17 @@ module.exports = {
},
'windows8':{
hostos : ['win32'],
- parser: './metadata/windows8_parser',
- url : 'https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git',
- version: '3.5.0',
- subdirectory: 'windows8'
+ parser: './metadata/windows_parser',
+ url : 'http://github.com/MSOpenTech/cordova-windows/archive/win81.tar.gz',
--- End diff --
TODO: must be updated with correct url
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6976 Add support for Windows Universa...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/39#discussion_r14055722
--- Diff: cordova-lib/src/cordova/lazy_load.js ---
@@ -75,6 +75,10 @@ function cordova_git(platform) {
}
var url = platforms[platform].url + ';a=snapshot;h=' + platforms[platform].version + ';sf=tgz';
+ var url = platforms[platform].url + ';a=snapshot;h=' + platforms[platform].version + ';sf=tgz';
+ if (platform == 'windows' || platform == 'windows8') {
--- End diff --
TODO: remove this since the code has landed to apache repo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---