You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2024/03/12 20:58:05 UTC
[PR] [MCOMPILER-584] Refresh page - Using Non-Javac Compilers [maven-compiler-plugin]
slawekjaranowski opened a new pull request, #231:
URL: https://github.com/apache/maven-compiler-plugin/pull/231
https://issues.apache.org/jira/browse/MCOMPILER-584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCOMPILER-584] Refresh page - Using Non-Javac Compilers [maven-compiler-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #231:
URL: https://github.com/apache/maven-compiler-plugin/pull/231#discussion_r1523756890
##########
src/site/apt/non-javac-compilers.apt.vm:
##########
@@ -46,7 +48,7 @@ Using Non-Javac Compilers
* <<<eclipse>>> with artifactId <<<plexus-compiler-eclipse>>>.
- * <<<jikes>>> with artifactId <<<plexus-compiler-jikes>>>.
+ * <<<javac-with-errorprone>>> with artifactId <<<plexus-compiler-javac-errorprone>>>.
Review Comment:
@CrazyHZM - requirements was added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCOMPILER-584] Refresh page - Using Non-Javac Compilers [maven-compiler-plugin]
Posted by "CrazyHZM (via GitHub)" <gi...@apache.org>.
CrazyHZM commented on code in PR #231:
URL: https://github.com/apache/maven-compiler-plugin/pull/231#discussion_r1522826527
##########
src/site/apt/non-javac-compilers.apt.vm:
##########
@@ -46,7 +48,7 @@ Using Non-Javac Compilers
* <<<eclipse>>> with artifactId <<<plexus-compiler-eclipse>>>.
- * <<<jikes>>> with artifactId <<<plexus-compiler-jikes>>>.
+ * <<<javac-with-errorprone>>> with artifactId <<<plexus-compiler-javac-errorprone>>>.
Review Comment:
javac-with-errorprone requires JDK 11+. Do you think this needs a special explanation?
https://codehaus-plexus.github.io/plexus-compiler/plexus-compilers/plexus-compiler-javac-errorprone/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCOMPILER-584] Refresh page - Using Non-Javac Compilers [maven-compiler-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #231:
URL: https://github.com/apache/maven-compiler-plugin/pull/231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org