You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/22 03:12:45 UTC

[GitHub] [spark] mundaym opened a new pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

mundaym opened a new pull request #29819:
URL: https://github.com/apache/spark/pull/29819


   …SinkSuite.
   
   The socket receive buffer size set in this test was too small for
   the StatsdSinkSuite tests to run reliably on some systems. For a
   test in this suite to run reliably the buffer needs to be large
   enough to hold all the data in the packets being sent in a test
   along with any additional kernel or protocol overhead. The amount
   of kernel overhead per packet can vary from system to system but is
   typically far higher than the protocol overhead.
   
   If the receive buffer is too small and fills up then packets are
   silently dropped. This leads to the test failing with a timeout.
   
   If the socket defaults to a larger receive buffer (normally true)
   then we should keep that size.
   
   As well as increasing the minimum buffer size I've also decoupled
   the datagram packet buffer size from the receive buffer size. The
   receive buffer should in general be far larger to account for the
   fact that multiple packets might be buffered, as well as the
   aforementioned overhead. Any truncated data in individual packets
   will be picked up by the tests.
   
   ### What changes were proposed in this pull request?
   
   Increase size of socket receive buffer in these tests.
   
   ### Why are the changes needed?
   
   The socket receive buffer size set is too small for some systems causing it to fill up, packets to be dropped and finally test timeouts.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, this only affects the tests.
   
   ### How was this patch tested?
   Existing tests on IBM Z and x86.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696995687


   **[Test build #128991 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128991/testReport)** for PR 29819 at commit [`9181c18`](https://github.com/apache/spark/commit/9181c18aa05d50f784ffb9025d65f46561e9db42).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696996605






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-702394560


   This is a small change to a test suite, to just increase a buffer size. I can't see that it's controversial or that a few more or less lines matters. Where are you getting that it has to be one line to backport??


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-702468320


   No, it's not a rule~ I wrote like that because I would do if I merge this PR.
   
   Feel free to proceed in your way, @srowen . I'll leave this to you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-703164124


   **[Test build #129381 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129381/testReport)** for PR 29819 at commit [`9181c18`](https://github.com/apache/spark/commit/9181c18aa05d50f784ffb9025d65f46561e9db42).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-702362911


   @mundaym What is the purpose of this contribution? Technically, this PR looks worth for a testing on specific machine types like IBM. Given that, the change looks a little too much. If we have one-liner, I believe we can cherry-pick to all live branches. Otherwise, maybe, this PR is limited to `master` only.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-703153210






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29819:
URL: https://github.com/apache/spark/pull/29819#discussion_r497979070



##########
File path: core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala
##########
@@ -35,12 +35,27 @@ class StatsdSinkSuite extends SparkFunSuite {
     STATSD_KEY_UNIT -> "seconds",
     STATSD_KEY_HOST -> "127.0.0.1"
   )
-  private val socketTimeout = 30000 // milliseconds
-  private val socketBufferSize = 8192
+  // The maximum size of a single datagram packet payload. Payloads
+  // larger than this will be truncated.
+  private val maxPayloadSize = 256 // bytes
+
+  // The receive buffer must be large enough to hold all inflight
+  // packets. This includes any kernel and protocol overhead.
+  // This value was determined experimentally and should be
+  // increased if timeouts are seen.
+  private val socketMinRecvBufferSize = 16384 // bytes
+  private val socketTimeout = 30000           // milliseconds

Review comment:
       Please move this to the original position to reduce the unnecessary diff and don't add space between `30000` and `// milliseconds`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696504272


   cc @jerryshao FYI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-703153202


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33989/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-703143308


   @mundaym are you looking for this to go into 3.0.x as well?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696152643


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696153406






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-703164368






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696152643


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen closed pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #29819:
URL: https://github.com/apache/spark/pull/29819


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696895879


   **[Test build #128991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128991/testReport)** for PR 29819 at commit [`9181c18`](https://github.com/apache/spark/commit/9181c18aa05d50f784ffb9025d65f46561e9db42).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696894772


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-703164368






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696896530






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696896530






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696996605






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] mundaym commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
mundaym commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-701985693


   Thanks for the review @dongjoon-hyun.
   
   > Why don't we simply use new value? Then, this PR can be one-liner.
   
   Could do. It's seems to me though that having the values the same misleadingly implies that the socket receive buffer should be the same size as the UDP payload, when in fact the socket receive buffer needs to be a lot bigger (multiple packets + kernel overhead). The more I think about though it the more I'm inclined to say we should just leave the size of the socket receive buffer alone (i.e. delete the `socket.setReceiveBufferSize` call completely). The default is always going to be large enough for this test, overriding it seems unnecessary.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-703143283


   Jenkins retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696152643






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696152643


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696895879


   **[Test build #128991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128991/testReport)** for PR 29819 at commit [`9181c18`](https://github.com/apache/spark/commit/9181c18aa05d50f784ffb9025d65f46561e9db42).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696895879


   **[Test build #128991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128991/testReport)** for PR 29819 at commit [`9181c18`](https://github.com/apache/spark/commit/9181c18aa05d50f784ffb9025d65f46561e9db42).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696895879






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-703143663


   **[Test build #129381 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129381/testReport)** for PR 29819 at commit [`9181c18`](https://github.com/apache/spark/commit/9181c18aa05d50f784ffb9025d65f46561e9db42).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696896530






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-703143663


   **[Test build #129381 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129381/testReport)** for PR 29819 at commit [`9181c18`](https://github.com/apache/spark/commit/9181c18aa05d50f784ffb9025d65f46561e9db42).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696153406


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696894772


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-703150084


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33989/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-703153210






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-704270819


   Merged to master/3.0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] mundaym commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

Posted by GitBox <gi...@apache.org>.
mundaym commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-704910397


   Thanks for reviewing this.
   
   > @mundaym are you looking for this to go into 3.0.x as well?
   > Merged to master/3.0
   
   Happy for this to be backported (looks like already done).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696153406


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in Statsd…

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29819:
URL: https://github.com/apache/spark/pull/29819#issuecomment-696504272


   cc @jerryshao FYI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org