[GitHub] spark pull request: [SPARK-2165] spark on yarn: add support for se...

[tgravescs <gi...@git.apache.org>]

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1279#discussion_r16371320
  
    --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -81,6 +81,10 @@ class Client(clientArgs: ClientArguments, hadoopConf: Configuration, spConf: Spa
         appContext.setQueue(args.amQueue)
         appContext.setAMContainerSpec(amContainer)
         appContext.setApplicationType("SPARK")
    +    sparkConf.getOption("spark.maxappattempts").map(_.toInt) match {
    --- End diff --
    
    lets make the config name yarn specific.   spark.yarn.maxappattempts.
    
    Also can you update the yarn documentation to include the new config and description.  lookin docs/running-on-yarn.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org