You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/02 12:39:51 UTC
[GitHub] [rocketmq] hzh0425 opened a new pull request, #5808: [RIP-59] Support DLedger Controller snapshot
hzh0425 opened a new pull request, #5808:
URL: https://github.com/apache/rocketmq/pull/5808
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Support DLedger Controller snapshot
In RocketMQ 5.0, the DLedger Controller component was introduced (RIP-44) to allow automatic master-slave switching. Briefly speaking, it is a strong consistent metadata center based on the DLedger (Raft), which stores metadata related to the Master/Slave selection.
However, given the lack of snapshot capability from the DLedger, the DLedger Controller would face the following problems:
1. The DLedger Controller requires replaying the complete log from the store while restarting the node to restore its state. This might cost a considerable amount of time once the log size gets large.
2. The log will continue to expand over time and is likely to cause insufficient storage space in the end.
Therefore, the DLedger Controller (or perhaps other future components which require DLedger (Raft) abilities) needs the snapshot capability from DLedger to enhance its space and time performance in certain aspects. This drives us to introduce this improvement.
The links to our (GitHub id: tsunghanjacktsai, hzh0425, TheR1sing3un) proposal are given below (both Google Docs and Shimo Docs versions were provided to prevent someone cannot access the specific app):
SHIMO: https://shimo.im/docs/WlArzngm9JhzY0A2
GOOGLE DOCS: https://docs.google.com/document/d/1jiKtv5WRDqlgZLGYK0oHuZww1r7KKrnTdRGf_eDIQy8/edit?usp=sharing
## Brief changelog
Support DLedger Controller snapshot
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on pull request #5808: [RIP-59] Support DLedger Controller snapshot
Posted by GitBox <gi...@apache.org>.
hzh0425 commented on PR #5808:
URL: https://github.com/apache/rocketmq/pull/5808#issuecomment-1380182535
@RongtongJin pls take a review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on pull request #5808: [RIP-59] Support DLedger Controller snapshot
Posted by GitBox <gi...@apache.org>.
hzh0425 commented on PR #5808:
URL: https://github.com/apache/rocketmq/pull/5808#issuecomment-1368914611
@tsunghanjacktsai Can you help to see why the new DLdger version still doesn't work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [RIP-59] Support DLedger Controller snapshot [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5808:
URL: https://github.com/apache/rocketmq/pull/5808#issuecomment-1945104198
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #5808: [RIP-59] Support DLedger Controller snapshot
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5808:
URL: https://github.com/apache/rocketmq/pull/5808#issuecomment-1368929693
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5808?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5808](https://codecov.io/gh/apache/rocketmq/pull/5808?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f008901) into [develop](https://codecov.io/gh/apache/rocketmq/commit/e1dfc0db5347059edf31237c0e62889644c0dff9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1dfc0d) will **increase** coverage by `0.08%`.
> The diff coverage is `65.53%`.
```diff
@@ Coverage Diff @@
## develop #5808 +/- ##
=============================================
+ Coverage 42.38% 42.46% +0.08%
- Complexity 8223 8265 +42
=============================================
Files 1060 1062 +2
Lines 73374 73566 +192
Branches 9602 9619 +17
=============================================
+ Hits 31096 31242 +146
- Misses 38364 38397 +33
- Partials 3914 3927 +13
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/5808?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/rocketmq/common/ControllerConfig.java](https://codecov.io/gh/apache/rocketmq/pull/5808/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQ29udHJvbGxlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ocketmq/controller/impl/manager/SyncStateInfo.java](https://codecov.io/gh/apache/rocketmq/pull/5808/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL21hbmFnZXIvU3luY1N0YXRlSW5mby5qYXZh) | `71.73% <45.83%> (-11.60%)` | :arrow_down: |
| [...pl/statemachine/DLedgerControllerStateMachine.java](https://codecov.io/gh/apache/rocketmq/pull/5808/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL3N0YXRlbWFjaGluZS9ETGVkZ2VyQ29udHJvbGxlclN0YXRlTWFjaGluZS5qYXZh) | `60.78% <50.00%> (ø)` | |
| [...tatemachine/StatemachineSnapshotFileGenerator.java](https://codecov.io/gh/apache/rocketmq/pull/5808/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL3N0YXRlbWFjaGluZS9TdGF0ZW1hY2hpbmVTbmFwc2hvdEZpbGVHZW5lcmF0b3IuamF2YQ==) | `71.95% <71.95%> (ø)` | |
| [...q/controller/impl/manager/MetadataManagerType.java](https://codecov.io/gh/apache/rocketmq/pull/5808/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL21hbmFnZXIvTWV0YWRhdGFNYW5hZ2VyVHlwZS5qYXZh) | `72.72% <72.72%> (ø)` | |
| [...e/rocketmq/controller/impl/manager/BrokerInfo.java](https://codecov.io/gh/apache/rocketmq/pull/5808/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL21hbmFnZXIvQnJva2VySW5mby5qYXZh) | `76.92% <76.00%> (-2.03%)` | :arrow_down: |
| [...q/controller/impl/manager/ReplicasInfoManager.java](https://codecov.io/gh/apache/rocketmq/pull/5808/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL21hbmFnZXIvUmVwbGljYXNJbmZvTWFuYWdlci5qYXZh) | `64.04% <90.47%> (+2.08%)` | :arrow_up: |
| [...he/rocketmq/controller/impl/DLedgerController.java](https://codecov.io/gh/apache/rocketmq/pull/5808/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL0RMZWRnZXJDb250cm9sbGVyLmphdmE=) | `67.01% <100.00%> (+0.51%)` | :arrow_up: |
| [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/5808/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `80.35% <0.00%> (-5.36%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/rocketmq/pull/5808/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on pull request #5808: [RIP-59] Support DLedger Controller snapshot
Posted by GitBox <gi...@apache.org>.
hzh0425 commented on PR #5808:
URL: https://github.com/apache/rocketmq/pull/5808#issuecomment-1369785245
>  @tsunghanjacktsai Can you help to see why the new DLdger version still doesn't work?
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org