You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Bruno Busco <br...@gmail.com> on 2009/02/21 19:10:54 UTC
Themes components should be loaded after the applications
I have seen that the themes are loaded after the framework component
and before the applications.
This cause an error when the newly added multiflex theme tries to
define its seeds because the VisualThemeSet it belongs to is defined
by the ecommerce application.
I think we should have the theme loaded after the application.
-Bruno
Re: Themes components should be loaded after the applications
Posted by Bruno Busco <br...@gmail.com>.
I created a JIRA with a patch for this:
https://issues.apache.org/jira/browse/OFBIZ-2201
Thank you,
-Bruno
2009/2/22 Bruno Busco <br...@gmail.com>:
> Hi David,
> the issue is this:
>
> In the ecommerce application a specific (to the ecommerce application)
> VisualThemeSet is defined:
> In EcommerceTypeData.xml:
> <VisualThemeSet visualThemeSetId="ECOMMERCE"
> description="ECommerce Visual Themes"/>
>
> The multiflex theme is defined as:
> <VisualTheme visualThemeId="MULTIFLEX"
> visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for
> Ecommerce"/>
>
> When doing "ant run-install" for the first time the
> visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity
> gets created.
>
> This is the reason I think themes should be loaded AFTER the
> applications because, actually, they apply ON applications.
>
> I have run a local test with this component-load.xml and it works well.
> <component-loader xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/component-loader.xsd">
> <load-components parent-directory="framework"/>
> <load-components parent-directory="applications"/>
> <load-components parent-directory="specialpurpose"/>
> <load-components parent-directory="themes"/>
> <load-components parent-directory="hot-deploy"/>
> </component-loader>
>
> Thank you,
> Bruno
>
>
> 2009/2/22 David E Jones <da...@hotwaxmedia.com>:
>>
>> It sounds like there is some sort of conflict between the theme and what is
>> in ecommerce.
>>
>> We may very well want to have the themes load after everything else... but
>> could you describe what is being overridden, ie what is conflicting? Is that
>> something that can be avoided?
>>
>> -David
>>
>>
>> On Feb 21, 2009, at 11:14 AM, Bruno Busco wrote:
>>
>>> For the moment, in order to have the multiflex theme available it is
>>> necessary to reload the seeds using webtools:
>>> https://localhost:8443/webtools/control/EntityImportReaders
>>>
>>> -Bruno
>>>
>>> 2009/2/21 Bruno Busco <br...@gmail.com>:
>>>>
>>>> I have seen that the themes are loaded after the framework component
>>>> and before the applications.
>>>> This cause an error when the newly added multiflex theme tries to
>>>> define its seeds because the VisualThemeSet it belongs to is defined
>>>> by the ecommerce application.
>>>>
>>>> I think we should have the theme loaded after the application.
>>>>
>>>> -Bruno
>>>>
>>
>>
>
Re: Themes components should be loaded after the applications
Posted by Jacques Le Roux <ja...@les7arts.com>.
Yes, of course I agree too (sorry for the commit did not thought about dependencies). Hopefully, from your advices, Bruno will find
a good solution
Jacques
From: "Jacopo Cappellato" <ja...@hotwaxmedia.com>
>I agree, I think I have proposed something very similar in my comment to:
>
> https://issues.apache.org/jira/browse/OFBIZ-2201
>
> Jacopo
>
>
> On Feb 24, 2009, at 12:02 AM, David E Jones wrote:
>
>>
>> A better solution would be to the VisualThemeSet definition to wherever the other one is defined, preferably to the framework
>> itself along with the other foundational theme resources.
>>
>> Don't think of this theme set as using ecommerce and therefore depends on ecommerce. In fact it's the other way around,
>> ecommerce depends on the theme set so the theme set doesn't need to be included but it does need to depend on whatever defines
>> the theme set.
>>
>> -David
>>
>>
>> On Feb 22, 2009, at 4:28 AM, Bruno Busco wrote:
>>
>>> Hi David,
>>> the issue is this:
>>>
>>> In the ecommerce application a specific (to the ecommerce application)
>>> VisualThemeSet is defined:
>>> In EcommerceTypeData.xml:
>>> <VisualThemeSet visualThemeSetId="ECOMMERCE"
>>> description="ECommerce Visual Themes"/>
>>>
>>> The multiflex theme is defined as:
>>> <VisualTheme visualThemeId="MULTIFLEX"
>>> visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for
>>> Ecommerce"/>
>>>
>>> When doing "ant run-install" for the first time the
>>> visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity
>>> gets created.
>>>
>>> This is the reason I think themes should be loaded AFTER the
>>> applications because, actually, they apply ON applications.
>>>
>>> I have run a local test with this component-load.xml and it works well.
>>> <component-loader xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance "
>>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/component-loader.xsd ">
>>> <load-components parent-directory="framework"/>
>>> <load-components parent-directory="applications"/>
>>> <load-components parent-directory="specialpurpose"/>
>>> <load-components parent-directory="themes"/>
>>> <load-components parent-directory="hot-deploy"/>
>>> </component-loader>
>>>
>>> Thank you,
>>> Bruno
>>>
>>>
>>> 2009/2/22 David E Jones <da...@hotwaxmedia.com>:
>>>>
>>>> It sounds like there is some sort of conflict between the theme and what is
>>>> in ecommerce.
>>>>
>>>> We may very well want to have the themes load after everything else... but
>>>> could you describe what is being overridden, ie what is conflicting? Is that
>>>> something that can be avoided?
>>>>
>>>> -David
>>>>
>>>>
>>>> On Feb 21, 2009, at 11:14 AM, Bruno Busco wrote:
>>>>
>>>>> For the moment, in order to have the multiflex theme available it is
>>>>> necessary to reload the seeds using webtools:
>>>>> https://localhost:8443/webtools/control/EntityImportReaders
>>>>>
>>>>> -Bruno
>>>>>
>>>>> 2009/2/21 Bruno Busco <br...@gmail.com>:
>>>>>>
>>>>>> I have seen that the themes are loaded after the framework component
>>>>>> and before the applications.
>>>>>> This cause an error when the newly added multiflex theme tries to
>>>>>> define its seeds because the VisualThemeSet it belongs to is defined
>>>>>> by the ecommerce application.
>>>>>>
>>>>>> I think we should have the theme loaded after the application.
>>>>>>
>>>>>> -Bruno
>>>>>>
>>>>
>>>>
>>
>
>
Re: Themes components should be loaded after the applications
Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
I agree, I think I have proposed something very similar in my comment
to:
https://issues.apache.org/jira/browse/OFBIZ-2201
Jacopo
On Feb 24, 2009, at 12:02 AM, David E Jones wrote:
>
> A better solution would be to the VisualThemeSet definition to
> wherever the other one is defined, preferably to the framework
> itself along with the other foundational theme resources.
>
> Don't think of this theme set as using ecommerce and therefore
> depends on ecommerce. In fact it's the other way around, ecommerce
> depends on the theme set so the theme set doesn't need to be
> included but it does need to depend on whatever defines the theme set.
>
> -David
>
>
> On Feb 22, 2009, at 4:28 AM, Bruno Busco wrote:
>
>> Hi David,
>> the issue is this:
>>
>> In the ecommerce application a specific (to the ecommerce
>> application)
>> VisualThemeSet is defined:
>> In EcommerceTypeData.xml:
>> <VisualThemeSet visualThemeSetId="ECOMMERCE"
>> description="ECommerce Visual Themes"/>
>>
>> The multiflex theme is defined as:
>> <VisualTheme visualThemeId="MULTIFLEX"
>> visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for
>> Ecommerce"/>
>>
>> When doing "ant run-install" for the first time the
>> visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity
>> gets created.
>>
>> This is the reason I think themes should be loaded AFTER the
>> applications because, actually, they apply ON applications.
>>
>> I have run a local test with this component-load.xml and it works
>> well.
>> <component-loader xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance
>> "
>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/component-loader.xsd
>> ">
>> <load-components parent-directory="framework"/>
>> <load-components parent-directory="applications"/>
>> <load-components parent-directory="specialpurpose"/>
>> <load-components parent-directory="themes"/>
>> <load-components parent-directory="hot-deploy"/>
>> </component-loader>
>>
>> Thank you,
>> Bruno
>>
>>
>> 2009/2/22 David E Jones <da...@hotwaxmedia.com>:
>>>
>>> It sounds like there is some sort of conflict between the theme
>>> and what is
>>> in ecommerce.
>>>
>>> We may very well want to have the themes load after everything
>>> else... but
>>> could you describe what is being overridden, ie what is
>>> conflicting? Is that
>>> something that can be avoided?
>>>
>>> -David
>>>
>>>
>>> On Feb 21, 2009, at 11:14 AM, Bruno Busco wrote:
>>>
>>>> For the moment, in order to have the multiflex theme available it
>>>> is
>>>> necessary to reload the seeds using webtools:
>>>> https://localhost:8443/webtools/control/EntityImportReaders
>>>>
>>>> -Bruno
>>>>
>>>> 2009/2/21 Bruno Busco <br...@gmail.com>:
>>>>>
>>>>> I have seen that the themes are loaded after the framework
>>>>> component
>>>>> and before the applications.
>>>>> This cause an error when the newly added multiflex theme tries to
>>>>> define its seeds because the VisualThemeSet it belongs to is
>>>>> defined
>>>>> by the ecommerce application.
>>>>>
>>>>> I think we should have the theme loaded after the application.
>>>>>
>>>>> -Bruno
>>>>>
>>>
>>>
>
Re: Themes components should be loaded after the applications
Posted by David E Jones <da...@hotwaxmedia.com>.
A better solution would be to the VisualThemeSet definition to
wherever the other one is defined, preferably to the framework itself
along with the other foundational theme resources.
Don't think of this theme set as using ecommerce and therefore depends
on ecommerce. In fact it's the other way around, ecommerce depends on
the theme set so the theme set doesn't need to be included but it does
need to depend on whatever defines the theme set.
-David
On Feb 22, 2009, at 4:28 AM, Bruno Busco wrote:
> Hi David,
> the issue is this:
>
> In the ecommerce application a specific (to the ecommerce application)
> VisualThemeSet is defined:
> In EcommerceTypeData.xml:
> <VisualThemeSet visualThemeSetId="ECOMMERCE"
> description="ECommerce Visual Themes"/>
>
> The multiflex theme is defined as:
> <VisualTheme visualThemeId="MULTIFLEX"
> visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for
> Ecommerce"/>
>
> When doing "ant run-install" for the first time the
> visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity
> gets created.
>
> This is the reason I think themes should be loaded AFTER the
> applications because, actually, they apply ON applications.
>
> I have run a local test with this component-load.xml and it works
> well.
> <component-loader xmlns:xsi="http://www.w3.org/2001/XMLSchema-
> instance"
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/component-loader.xsd
> ">
> <load-components parent-directory="framework"/>
> <load-components parent-directory="applications"/>
> <load-components parent-directory="specialpurpose"/>
> <load-components parent-directory="themes"/>
> <load-components parent-directory="hot-deploy"/>
> </component-loader>
>
> Thank you,
> Bruno
>
>
> 2009/2/22 David E Jones <da...@hotwaxmedia.com>:
>>
>> It sounds like there is some sort of conflict between the theme and
>> what is
>> in ecommerce.
>>
>> We may very well want to have the themes load after everything
>> else... but
>> could you describe what is being overridden, ie what is
>> conflicting? Is that
>> something that can be avoided?
>>
>> -David
>>
>>
>> On Feb 21, 2009, at 11:14 AM, Bruno Busco wrote:
>>
>>> For the moment, in order to have the multiflex theme available it is
>>> necessary to reload the seeds using webtools:
>>> https://localhost:8443/webtools/control/EntityImportReaders
>>>
>>> -Bruno
>>>
>>> 2009/2/21 Bruno Busco <br...@gmail.com>:
>>>>
>>>> I have seen that the themes are loaded after the framework
>>>> component
>>>> and before the applications.
>>>> This cause an error when the newly added multiflex theme tries to
>>>> define its seeds because the VisualThemeSet it belongs to is
>>>> defined
>>>> by the ecommerce application.
>>>>
>>>> I think we should have the theme loaded after the application.
>>>>
>>>> -Bruno
>>>>
>>
>>
Re: Themes components should be loaded after the applications
Posted by Bruno Busco <br...@gmail.com>.
Hi David,
the issue is this:
In the ecommerce application a specific (to the ecommerce application)
VisualThemeSet is defined:
In EcommerceTypeData.xml:
<VisualThemeSet visualThemeSetId="ECOMMERCE"
description="ECommerce Visual Themes"/>
The multiflex theme is defined as:
<VisualTheme visualThemeId="MULTIFLEX"
visualThemeSetId="ECOMMERCE" description="Alternative VisualTheme for
Ecommerce"/>
When doing "ant run-install" for the first time the
visualThemeSetId="ECOMMERCE" is not found when the VisualTheme entity
gets created.
This is the reason I think themes should be loaded AFTER the
applications because, actually, they apply ON applications.
I have run a local test with this component-load.xml and it works well.
<component-loader xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/component-loader.xsd">
<load-components parent-directory="framework"/>
<load-components parent-directory="applications"/>
<load-components parent-directory="specialpurpose"/>
<load-components parent-directory="themes"/>
<load-components parent-directory="hot-deploy"/>
</component-loader>
Thank you,
Bruno
2009/2/22 David E Jones <da...@hotwaxmedia.com>:
>
> It sounds like there is some sort of conflict between the theme and what is
> in ecommerce.
>
> We may very well want to have the themes load after everything else... but
> could you describe what is being overridden, ie what is conflicting? Is that
> something that can be avoided?
>
> -David
>
>
> On Feb 21, 2009, at 11:14 AM, Bruno Busco wrote:
>
>> For the moment, in order to have the multiflex theme available it is
>> necessary to reload the seeds using webtools:
>> https://localhost:8443/webtools/control/EntityImportReaders
>>
>> -Bruno
>>
>> 2009/2/21 Bruno Busco <br...@gmail.com>:
>>>
>>> I have seen that the themes are loaded after the framework component
>>> and before the applications.
>>> This cause an error when the newly added multiflex theme tries to
>>> define its seeds because the VisualThemeSet it belongs to is defined
>>> by the ecommerce application.
>>>
>>> I think we should have the theme loaded after the application.
>>>
>>> -Bruno
>>>
>
>
Re: Themes components should be loaded after the applications
Posted by David E Jones <da...@hotwaxmedia.com>.
It sounds like there is some sort of conflict between the theme and
what is in ecommerce.
We may very well want to have the themes load after everything else...
but could you describe what is being overridden, ie what is
conflicting? Is that something that can be avoided?
-David
On Feb 21, 2009, at 11:14 AM, Bruno Busco wrote:
> For the moment, in order to have the multiflex theme available it is
> necessary to reload the seeds using webtools:
> https://localhost:8443/webtools/control/EntityImportReaders
>
> -Bruno
>
> 2009/2/21 Bruno Busco <br...@gmail.com>:
>> I have seen that the themes are loaded after the framework component
>> and before the applications.
>> This cause an error when the newly added multiflex theme tries to
>> define its seeds because the VisualThemeSet it belongs to is defined
>> by the ecommerce application.
>>
>> I think we should have the theme loaded after the application.
>>
>> -Bruno
>>
Re: Themes components should be loaded after the applications
Posted by Bruno Busco <br...@gmail.com>.
For the moment, in order to have the multiflex theme available it is
necessary to reload the seeds using webtools:
https://localhost:8443/webtools/control/EntityImportReaders
-Bruno
2009/2/21 Bruno Busco <br...@gmail.com>:
> I have seen that the themes are loaded after the framework component
> and before the applications.
> This cause an error when the newly added multiflex theme tries to
> define its seeds because the VisualThemeSet it belongs to is defined
> by the ecommerce application.
>
> I think we should have the theme loaded after the application.
>
> -Bruno
>