You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/24 02:14:30 UTC
Review Request 12887: Style /browse to distinguish folders
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Style /browse to distinguish folders
* Add small folder icons to the left of folders to distinguish them
from other files.
* Right align Size, Nlink, and mtime columns.
* Remove 'name' title since it is apparent
* Order files first by file type, i.e. folder or not folder, and then
by name.
Diffs
-----
src/webui/master/static/browse.html 366e99978554916feb7be962d4f1df8fd93773cc
Diff: https://reviews.apache.org/r/12887/diff/
Testing
-------
File Attachments
----------------
Pre-commit browse
https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
Post-commit browse
https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
Thanks,
Ross Allen
Re: Review Request 12887: Style /browse to distinguish folders
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 25, 2013, 9:05 p.m., Ben Mahler wrote:
> > src/webui/master/static/browse.html, lines 42-43
> > <https://reviews.apache.org/r/12887/diff/1/?file=326197#file326197line42>
> >
> > Looks a bit odd that some are right aligned, and some are left aligned IMO, was this the cleanest look?
>
> Ross Allen wrote:
> I was sticking to the layout of `ls`. I think the mtime column is justified rather than aligned, but otherwise the right/left alignment matches `ls`.
>
> Ben Mahler wrote:
> Ah, I should have clarified that I was referring to the table headers only, I think the columns are ok, is it possible to have the titles all right aligned over the column text?
>
> Right Title
> Left Aligned Body
>
> Either way, looks good!
Check out the screenshots I just attached. Having the headers all right-aligned with some left-aligned content makes it difficult to tell which header belongs to which column.
I think it makes sense to have the header aligned the same as the column content.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/#review23865
-----------------------------------------------------------
On July 26, 2013, 6:57 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12887/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 6:57 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style /browse to distinguish folders
>
> * Add small folder icons to the left of folders to distinguish them
> from other files.
> * Right align Size, Nlink, and mtime columns.
> * Remove 'name' title since it is apparent
> * Order files first by file type, i.e. folder or not folder, and then
> by name.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 366e99978554916feb7be962d4f1df8fd93773cc
>
> Diff: https://reviews.apache.org/r/12887/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Pre-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
> Post-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
> Right-aligned headers
> https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.18_AM.png
> Headers aligned same as column
> https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.25_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12887: Style /browse to distinguish folders
Posted by Ben Mahler <be...@gmail.com>.
> On July 25, 2013, 9:05 p.m., Ben Mahler wrote:
> > src/webui/master/static/browse.html, lines 42-43
> > <https://reviews.apache.org/r/12887/diff/1/?file=326197#file326197line42>
> >
> > Looks a bit odd that some are right aligned, and some are left aligned IMO, was this the cleanest look?
>
> Ross Allen wrote:
> I was sticking to the layout of `ls`. I think the mtime column is justified rather than aligned, but otherwise the right/left alignment matches `ls`.
Ah, I should have clarified that I was referring to the table headers only, I think the columns are ok, is it possible to have the titles all right aligned over the column text?
Right Title
Left Aligned Body
Either way, looks good!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/#review23865
-----------------------------------------------------------
On July 24, 2013, 12:14 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12887/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 12:14 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style /browse to distinguish folders
>
> * Add small folder icons to the left of folders to distinguish them
> from other files.
> * Right align Size, Nlink, and mtime columns.
> * Remove 'name' title since it is apparent
> * Order files first by file type, i.e. folder or not folder, and then
> by name.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 366e99978554916feb7be962d4f1df8fd93773cc
>
> Diff: https://reviews.apache.org/r/12887/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Pre-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
> Post-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12887: Style /browse to distinguish folders
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 25, 2013, 9:05 p.m., Ben Mahler wrote:
> > src/webui/master/static/browse.html, lines 42-43
> > <https://reviews.apache.org/r/12887/diff/1/?file=326197#file326197line42>
> >
> > Looks a bit odd that some are right aligned, and some are left aligned IMO, was this the cleanest look?
I was sticking to the layout of `ls`. I think the mtime column is justified rather than aligned, but otherwise the right/left alignment matches `ls`.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/#review23865
-----------------------------------------------------------
On July 24, 2013, 12:14 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12887/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 12:14 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style /browse to distinguish folders
>
> * Add small folder icons to the left of folders to distinguish them
> from other files.
> * Right align Size, Nlink, and mtime columns.
> * Remove 'name' title since it is apparent
> * Order files first by file type, i.e. folder or not folder, and then
> by name.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 366e99978554916feb7be962d4f1df8fd93773cc
>
> Diff: https://reviews.apache.org/r/12887/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Pre-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
> Post-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12887: Style /browse to distinguish folders
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/#review23865
-----------------------------------------------------------
Nice!
src/webui/master/static/browse.html
<https://reviews.apache.org/r/12887/#comment47691>
Looks a bit odd that some are right aligned, and some are left aligned IMO, was this the cleanest look?
- Ben Mahler
On July 24, 2013, 12:14 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12887/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 12:14 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style /browse to distinguish folders
>
> * Add small folder icons to the left of folders to distinguish them
> from other files.
> * Right align Size, Nlink, and mtime columns.
> * Remove 'name' title since it is apparent
> * Order files first by file type, i.e. folder or not folder, and then
> by name.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 366e99978554916feb7be962d4f1df8fd93773cc
>
> Diff: https://reviews.apache.org/r/12887/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Pre-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
> Post-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12887: Style /browse to distinguish folders
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 25, 2013, 11:55 p.m., Ben Mahler wrote:
> > src/webui/master/static/browse.html, lines 79-82
> > <https://reviews.apache.org/r/12887/diff/1/?file=326197#file326197line79>
> >
> > Does this still render well when there are no files?
I added a "No files in this directory." message when the file list is empty.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/#review23894
-----------------------------------------------------------
On July 26, 2013, 7:03 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12887/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 7:03 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style /browse to distinguish folders
>
> * Add small folder icons to the left of folders to distinguish them
> from other files.
> * Right align Size, Nlink, and mtime columns.
> * Remove 'name' title since it is apparent
> * Order files first by file type, i.e. folder or not folder, and then
> by name.
>
> Review: http://reviews.apache.org/r/12887
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 366e99978554916feb7be962d4f1df8fd93773cc
>
> Diff: https://reviews.apache.org/r/12887/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Pre-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
> Post-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
> Right-aligned headers
> https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.18_AM.png
> Headers aligned same as column
> https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.25_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12887: Style /browse to distinguish folders
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/#review23894
-----------------------------------------------------------
src/webui/master/static/browse.html
<https://reviews.apache.org/r/12887/#comment47717>
Does this still render well when there are no files?
- Ben Mahler
On July 24, 2013, 12:14 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12887/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 12:14 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style /browse to distinguish folders
>
> * Add small folder icons to the left of folders to distinguish them
> from other files.
> * Right align Size, Nlink, and mtime columns.
> * Remove 'name' title since it is apparent
> * Order files first by file type, i.e. folder or not folder, and then
> by name.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 366e99978554916feb7be962d4f1df8fd93773cc
>
> Diff: https://reviews.apache.org/r/12887/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Pre-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
> Post-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12887: Style /browse to distinguish folders
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 26, 2013, 10:34 p.m., Ben Mahler wrote:
> > src/webui/master/static/browse.html, lines 34-37
> > <https://reviews.apache.org/r/12887/diff/1-2/?file=326197#file326197line34>
> >
> > Nice! We should consider adding a ".." folder as well to all the listings if that makes it nicer to navigate up folders.
That might be worthwhile and very `ls`-like. Since the path is at the top of this page, and it acts as navigation, I will hold off on the ".." for right now.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/#review23987
-----------------------------------------------------------
On July 26, 2013, 7:03 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12887/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 7:03 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style /browse to distinguish folders
>
> * Add small folder icons to the left of folders to distinguish them
> from other files.
> * Right align Size, Nlink, and mtime columns.
> * Remove 'name' title since it is apparent
> * Order files first by file type, i.e. folder or not folder, and then
> by name.
>
> Review: http://reviews.apache.org/r/12887
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 366e99978554916feb7be962d4f1df8fd93773cc
>
> Diff: https://reviews.apache.org/r/12887/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Pre-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
> Post-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
> Right-aligned headers
> https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.18_AM.png
> Headers aligned same as column
> https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.25_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12887: Style /browse to distinguish folders
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/#review23987
-----------------------------------------------------------
Ship it!
src/webui/master/static/browse.html
<https://reviews.apache.org/r/12887/#comment47804>
Nice! We should consider adding a ".." folder as well to all the listings if that makes it nicer to navigate up folders.
- Ben Mahler
On July 26, 2013, 7:03 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12887/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 7:03 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style /browse to distinguish folders
>
> * Add small folder icons to the left of folders to distinguish them
> from other files.
> * Right align Size, Nlink, and mtime columns.
> * Remove 'name' title since it is apparent
> * Order files first by file type, i.e. folder or not folder, and then
> by name.
>
> Review: http://reviews.apache.org/r/12887
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 366e99978554916feb7be962d4f1df8fd93773cc
>
> Diff: https://reviews.apache.org/r/12887/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Pre-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
> Post-commit browse
> https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
> Right-aligned headers
> https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.18_AM.png
> Headers aligned same as column
> https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.25_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12887: Style /browse to distinguish folders
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/
-----------------------------------------------------------
(Updated July 26, 2013, 7:03 p.m.)
Review request for mesos.
Changes
-------
Added "No files in this directory." message when the file list is empty.
Repository: mesos-git
Description (updated)
-------
Style /browse to distinguish folders
* Add small folder icons to the left of folders to distinguish them
from other files.
* Right align Size, Nlink, and mtime columns.
* Remove 'name' title since it is apparent
* Order files first by file type, i.e. folder or not folder, and then
by name.
Review: http://reviews.apache.org/r/12887
Diffs (updated)
-----
src/webui/master/static/browse.html 366e99978554916feb7be962d4f1df8fd93773cc
Diff: https://reviews.apache.org/r/12887/diff/
Testing
-------
File Attachments
----------------
Pre-commit browse
https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
Post-commit browse
https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
Right-aligned headers
https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.18_AM.png
Headers aligned same as column
https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.25_AM.png
Thanks,
Ross Allen
Re: Review Request 12887: Style /browse to distinguish folders
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12887/
-----------------------------------------------------------
(Updated July 26, 2013, 6:57 p.m.)
Review request for mesos.
Changes
-------
Added screenshots demonstrating right/left-aligned headers.
Repository: mesos-git
Description
-------
Style /browse to distinguish folders
* Add small folder icons to the left of folders to distinguish them
from other files.
* Right align Size, Nlink, and mtime columns.
* Remove 'name' title since it is apparent
* Order files first by file type, i.e. folder or not folder, and then
by name.
Diffs
-----
src/webui/master/static/browse.html 366e99978554916feb7be962d4f1df8fd93773cc
Diff: https://reviews.apache.org/r/12887/diff/
Testing
-------
File Attachments (updated)
----------------
Pre-commit browse
https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.13.32_PM.png
Post-commit browse
https://reviews.apache.org/media/uploaded/files/2013/07/24/Screen_Shot_2013-07-23_at_5.09.23_PM.png
Right-aligned headers
https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.18_AM.png
Headers aligned same as column
https://reviews.apache.org/media/uploaded/files/2013/07/26/Screen_Shot_2013-07-26_at_11.56.25_AM.png
Thanks,
Ross Allen