You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/01/27 05:14:22 UTC
Review Request 42844: Drop `404 NotFound` responses in the executor
library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42844/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
Previously, we did not use to drop `404 NotFound` responses in the library and send `Event::Error` to executor. However, this can be trigerred upon an agent restart when it has not yet set up HTTP routes.
Diffs
-----
src/executor/executor.cpp 92334ffb8af83b1c86c44bd406147893c7c6daa3
Diff: https://reviews.apache.org/r/42844/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42844: Drop `404 NotFound` responses in the
executor library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42844/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 2:32 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Modifed deps
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
Previously, we did not use to drop `404 NotFound` responses in the library and send `Event::Error` to executor. However, this can be trigerred upon an agent restart when it has not yet set up HTTP routes.
Diffs
-----
src/executor/executor.cpp 92334ffb8af83b1c86c44bd406147893c7c6daa3
Diff: https://reviews.apache.org/r/42844/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42844: Drop `404 NotFound` responses in the
executor library.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42844/#review117498
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 27, 2016, 4:14 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42844/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 4:14 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we did not use to drop `404 NotFound` responses in the library and send `Event::Error` to executor. However, this can be trigerred upon an agent restart when it has not yet set up HTTP routes.
>
>
> Diffs
> -----
>
> src/executor/executor.cpp 92334ffb8af83b1c86c44bd406147893c7c6daa3
>
> Diff: https://reviews.apache.org/r/42844/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>