You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Timo Rantalaiho <Ti...@ri.fi> on 2008/09/29 05:10:29 UTC
SignIn2Test fails in current trunk and 1.3.x?
Hello,
What could have caused this test failure?
Signin2Test.testSignIn2 (org.apache.wicket.examples.signin2)
junit.framework.AssertionFailedError: expected:<Home> but was:<PageExpiredErrorPage>
at org.apache.wicket.util.tester.WicketTester.assertResult(WicketTester.java:575)
at org.apache.wicket.util.tester.WicketTester.assertRenderedPage(WicketTester.java:522)
http://wicketstuff.org/teamcity/viewLog.html?tab=buildResultsDiv&buildTypeId=bt4&buildId=1818
http://wicketstuff.org/teamcity/viewLog.html?tab=buildResultsDiv&buildTypeId=bt2&buildId=1819
I realised that by dropping CryptedUrlWebRequestCodingStrategy
======== clip ====================================================
Index: jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/signin2/SignIn2Application.java
===================================================================
--- jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/signin2/SignIn2Application.java (revision 699964)
+++ jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/signin2/SignIn2Application.java Mon Sep 29 06:01:02 EEST 2008
-
- /**
- * @see org.apache.wicket.protocol.http.WebApplication#newRequestCycleProcessor()
- */
- protected IRequestCycleProcessor newRequestCycleProcessor()
- {
- return new WebRequestCycleProcessor()
- {
- protected IRequestCodingStrategy newRequestCodingStrategy()
- {
- return new CryptedUrlWebRequestCodingStrategy(new WebRequestCodingStrategy());
- }
+}
- };
- }
-
-}
======== clap ====================================================
the test passes, but it would be nice to understand whether the
failure is caused by a bug in the test,
CryptedUrlWebRequestCodingStrategy or what.
It seems that AbstractRequestCycleProcessor.resolveRenderedPage()
cannot find the rendered page with Session.getPage(), which is
a bit suspicious.
Best wishes,
Timo
--
Timo Rantalaiho
Reaktor Innovations Oy <URL: http://www.ri.fi/ >
Re: SignIn2Test fails in current trunk and 1.3.x?
Posted by Igor Vaynberg <ig...@gmail.com>.
looks like my fault
the problem is in mockhttpservletrequest#setRequestToComponent
when tester tries to generate a callback it builds the url manually in
that method ignoring the current coding strategy, this used to break
the url compressor tests. i tried to make it automatic, but as you saw
didnt really work out. i had to add some special handling for crypted
strategy, should work ok now...
-igor
On Sun, Sep 28, 2008 at 8:10 PM, Timo Rantalaiho <Ti...@ri.fi> wrote:
> Hello,
>
> What could have caused this test failure?
>
> Signin2Test.testSignIn2 (org.apache.wicket.examples.signin2)
> junit.framework.AssertionFailedError: expected:<Home> but was:<PageExpiredErrorPage>
> at org.apache.wicket.util.tester.WicketTester.assertResult(WicketTester.java:575)
> at org.apache.wicket.util.tester.WicketTester.assertRenderedPage(WicketTester.java:522)
>
> http://wicketstuff.org/teamcity/viewLog.html?tab=buildResultsDiv&buildTypeId=bt4&buildId=1818
>
> http://wicketstuff.org/teamcity/viewLog.html?tab=buildResultsDiv&buildTypeId=bt2&buildId=1819
>
> I realised that by dropping CryptedUrlWebRequestCodingStrategy
>
> ======== clip ====================================================
>
> Index: jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/signin2/SignIn2Application.java
> ===================================================================
> --- jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/signin2/SignIn2Application.java (revision 699964)
> +++ jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/signin2/SignIn2Application.java Mon Sep 29 06:01:02 EEST 2008
> -
> - /**
> - * @see org.apache.wicket.protocol.http.WebApplication#newRequestCycleProcessor()
> - */
> - protected IRequestCycleProcessor newRequestCycleProcessor()
> - {
> - return new WebRequestCycleProcessor()
> - {
> - protected IRequestCodingStrategy newRequestCodingStrategy()
> - {
> - return new CryptedUrlWebRequestCodingStrategy(new WebRequestCodingStrategy());
> - }
> +}
> - };
> - }
> -
> -}
>
> ======== clap ====================================================
>
> the test passes, but it would be nice to understand whether the
> failure is caused by a bug in the test,
> CryptedUrlWebRequestCodingStrategy or what.
>
> It seems that AbstractRequestCycleProcessor.resolveRenderedPage()
> cannot find the rendered page with Session.getPage(), which is
> a bit suspicious.
>
> Best wishes,
> Timo
>
> --
> Timo Rantalaiho
> Reaktor Innovations Oy <URL: http://www.ri.fi/ >
>