You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Leif Hedstrom <zw...@apache.org> on 2018/01/16 19:11:08 UTC
[DISCUSS] Move pagespeed plugin to the Pagespeed Incubator project
Hi all,
The Pagespeed project recently moved from Google over to the Apache Incubator! I’d like to move our ATS plugin over to their project for v8.0. This is simply to make it a lot easier to build, and maintain, the ATS Pagespeed plugin. It also allows for a much better integration with the library development and releases.
Any concerns ?
Cheers,
— Leif
Re: [DISCUSS] Move pagespeed plugin to the Pagespeed Incubator project
Posted by Otto van der Schaaf <os...@gmail.com>.
So ... Actually, yes you are right and I agree centralizing the plugins
makes sense. A separate repo is easiest in the short term for
ats_pagespeed, and I do think that migrating ngx_pagespeed will need some
consideration but there are major benefits. And it is probably a good time
right now to figure out how to best accomplish centralizing them all while
we are at it. Let me raise a thread on the pagespeed dev list on the
subject.
Otto
On Sat, 20 Jan 2018 at 23:41, Leif Hedstrom <zw...@apache.org> wrote:
> Really? We want separate repos? That seems completely nonintuitive, and
> kind of defeats the purpose of moving this to Pagespeed in the first place ?
>
> The idea would be that you type make in Pagespeed to build the core
> library, and all plugins for various web servers, no?
>
> Cheers,
>
> — Leif
>
> > On Jan 20, 2018, at 19:17, Otto van der Schaaf <os...@gmail.com>
> wrote:
> >
> > Yes, sure. It would probably be best to have this in a new repo, e.g.:
> > https://github.com/apache/incubator-pagespeed-ats.git
> >
> > Do you know who do I need to contact to see if initializing a new repo is
> > possible?
> >
> > Otto
> >
> >
> >> On Fri, Jan 19, 2018 at 7:27 AM Leif Hedstrom <zw...@apache.org> wrote:
> >>
> >>
> >>
> >>> On Jan 18, 2018, at 2:02 AM, Alan Carroll <solidwallofcode@oath.com
> .INVALID>
> >> wrote:
> >>>
> >>> +1
> >>
> >>
> >> Seems like we should do this. Otto, do you want to do the honors of
> moving
> >> this to the Pagespeed Git repo? Once done, I’ll also mark the plugin as
> >> deprecated in the 7.1.x tree, with a reference to the new project.
> >>
> >> Cheers,
> >>
> >> — Leif
> >>
> >>
>
>
Re: [DISCUSS] Move pagespeed plugin to the Pagespeed Incubator project
Posted by Otto van der Schaaf <os...@gmail.com>.
For those interested, I moved the discussion on how to migrate the plugin
into the PageSpeed project to
https://lists.apache.org/thread.html/cef517bd129be5dab55a9b1191613356c94cecbefcf91de10a96289f@%3Cdev.pagespeed.apache.org%3E
On Sun, Jan 21, 2018 at 12:50 AM Kees Spoelstra <ks...@we-amp.com>
wrote:
> Disregard, wrong mailinglist... Apologies
>
> On Jan 21, 2018 00:48, "Kees Spoelstra" <ks...@we-amp.com> wrote:
>
> I don't know, actually having an option to pull in the pre made pagespeed
> automatic library would be great... But that could be done from one repo
> also.
>
> Compiling pagespeed or a plugin are two completely different things in
> compile time, complexity and dependencies.
>
> Will we be moving ngx_pagespeed also to this model?
>
> So in the end this comes down to how we are going to distribute stuff.
> Will we have precompiled pagespeed automatic libraries to facilitate low
> entry plugin building (ngx, ats?) or do we want the people to have long
> compilation times and possibly have a negative feeling about this and
> disregard the product because of that. It is now pretty low entry.
>
> I think we need both options from the same repo, but some people won't know
> what hit them, as ngx pagespeed is pretty small right now and pulling in
> the complete repo is something else alktogether...
>
> What are your thoughts about this?
>
>
>
>
>
>
>
> On Jan 20, 2018 23:42, "Leif Hedstrom" <zw...@apache.org> wrote:
>
> Really? We want separate repos? That seems completely nonintuitive, and
> kind of defeats the purpose of moving this to Pagespeed in the first place
> ?
>
> The idea would be that you type make in Pagespeed to build the core
> library, and all plugins for various web servers, no?
>
> Cheers,
>
> — Leif
>
> > On Jan 20, 2018, at 19:17, Otto van der Schaaf <os...@gmail.com>
> wrote:
> >
> > Yes, sure. It would probably be best to have this in a new repo, e.g.:
> > https://github.com/apache/incubator-pagespeed-ats.git
> >
> > Do you know who do I need to contact to see if initializing a new repo is
> > possible?
> >
> > Otto
> >
> >
> >> On Fri, Jan 19, 2018 at 7:27 AM Leif Hedstrom <zw...@apache.org> wrote:
> >>
> >>
> >>
> >>> On Jan 18, 2018, at 2:02 AM, Alan Carroll
> <solidwallofcode@oath.com.INVA
> LID>
> >> wrote:
> >>>
> >>> +1
> >>
> >>
> >> Seems like we should do this. Otto, do you want to do the honors of
> moving
> >> this to the Pagespeed Git repo? Once done, I’ll also mark the plugin as
> >> deprecated in the 7.1.x tree, with a reference to the new project.
> >>
> >> Cheers,
> >>
> >> — Leif
> >>
> >>
>
Re: [DISCUSS] Move pagespeed plugin to the Pagespeed Incubator project
Posted by Kees Spoelstra <ks...@we-amp.com>.
Disregard, wrong mailinglist... Apologies
On Jan 21, 2018 00:48, "Kees Spoelstra" <ks...@we-amp.com> wrote:
I don't know, actually having an option to pull in the pre made pagespeed
automatic library would be great... But that could be done from one repo
also.
Compiling pagespeed or a plugin are two completely different things in
compile time, complexity and dependencies.
Will we be moving ngx_pagespeed also to this model?
So in the end this comes down to how we are going to distribute stuff.
Will we have precompiled pagespeed automatic libraries to facilitate low
entry plugin building (ngx, ats?) or do we want the people to have long
compilation times and possibly have a negative feeling about this and
disregard the product because of that. It is now pretty low entry.
I think we need both options from the same repo, but some people won't know
what hit them, as ngx pagespeed is pretty small right now and pulling in
the complete repo is something else alktogether...
What are your thoughts about this?
On Jan 20, 2018 23:42, "Leif Hedstrom" <zw...@apache.org> wrote:
Really? We want separate repos? That seems completely nonintuitive, and
kind of defeats the purpose of moving this to Pagespeed in the first place ?
The idea would be that you type make in Pagespeed to build the core
library, and all plugins for various web servers, no?
Cheers,
— Leif
> On Jan 20, 2018, at 19:17, Otto van der Schaaf <os...@gmail.com> wrote:
>
> Yes, sure. It would probably be best to have this in a new repo, e.g.:
> https://github.com/apache/incubator-pagespeed-ats.git
>
> Do you know who do I need to contact to see if initializing a new repo is
> possible?
>
> Otto
>
>
>> On Fri, Jan 19, 2018 at 7:27 AM Leif Hedstrom <zw...@apache.org> wrote:
>>
>>
>>
>>> On Jan 18, 2018, at 2:02 AM, Alan Carroll <solidwallofcode@oath.com.INVA
LID>
>> wrote:
>>>
>>> +1
>>
>>
>> Seems like we should do this. Otto, do you want to do the honors of
moving
>> this to the Pagespeed Git repo? Once done, I’ll also mark the plugin as
>> deprecated in the 7.1.x tree, with a reference to the new project.
>>
>> Cheers,
>>
>> — Leif
>>
>>
Re: [DISCUSS] Move pagespeed plugin to the Pagespeed Incubator project
Posted by Kees Spoelstra <ks...@we-amp.com>.
I don't know, actually having an option to pull in the pre made pagespeed
automatic library would be great... But that could be done from one repo
also.
Compiling pagespeed or a plugin are two completely different things in
compile time, complexity and dependencies.
Will we be moving ngx_pagespeed also to this model?
So in the end this comes down to how we are going to distribute stuff.
Will we have precompiled pagespeed automatic libraries to facilitate low
entry plugin building (ngx, ats?) or do we want the people to have long
compilation times and possibly have a negative feeling about this and
disregard the product because of that. It is now pretty low entry.
I think we need both options from the same repo, but some people won't know
what hit them, as ngx pagespeed is pretty small right now and pulling in
the complete repo is something else alktogether...
What are your thoughts about this?
On Jan 20, 2018 23:42, "Leif Hedstrom" <zw...@apache.org> wrote:
Really? We want separate repos? That seems completely nonintuitive, and
kind of defeats the purpose of moving this to Pagespeed in the first place ?
The idea would be that you type make in Pagespeed to build the core
library, and all plugins for various web servers, no?
Cheers,
— Leif
> On Jan 20, 2018, at 19:17, Otto van der Schaaf <os...@gmail.com> wrote:
>
> Yes, sure. It would probably be best to have this in a new repo, e.g.:
> https://github.com/apache/incubator-pagespeed-ats.git
>
> Do you know who do I need to contact to see if initializing a new repo is
> possible?
>
> Otto
>
>
>> On Fri, Jan 19, 2018 at 7:27 AM Leif Hedstrom <zw...@apache.org> wrote:
>>
>>
>>
>>> On Jan 18, 2018, at 2:02 AM, Alan Carroll <solidwallofcode@oath.com.
INVALID>
>> wrote:
>>>
>>> +1
>>
>>
>> Seems like we should do this. Otto, do you want to do the honors of
moving
>> this to the Pagespeed Git repo? Once done, I’ll also mark the plugin as
>> deprecated in the 7.1.x tree, with a reference to the new project.
>>
>> Cheers,
>>
>> — Leif
>>
>>
Re: [DISCUSS] Move pagespeed plugin to the Pagespeed Incubator project
Posted by Leif Hedstrom <zw...@apache.org>.
Really? We want separate repos? That seems completely nonintuitive, and kind of defeats the purpose of moving this to Pagespeed in the first place ?
The idea would be that you type make in Pagespeed to build the core library, and all plugins for various web servers, no?
Cheers,
— Leif
> On Jan 20, 2018, at 19:17, Otto van der Schaaf <os...@gmail.com> wrote:
>
> Yes, sure. It would probably be best to have this in a new repo, e.g.:
> https://github.com/apache/incubator-pagespeed-ats.git
>
> Do you know who do I need to contact to see if initializing a new repo is
> possible?
>
> Otto
>
>
>> On Fri, Jan 19, 2018 at 7:27 AM Leif Hedstrom <zw...@apache.org> wrote:
>>
>>
>>
>>> On Jan 18, 2018, at 2:02 AM, Alan Carroll <so...@oath.com.INVALID>
>> wrote:
>>>
>>> +1
>>
>>
>> Seems like we should do this. Otto, do you want to do the honors of moving
>> this to the Pagespeed Git repo? Once done, I’ll also mark the plugin as
>> deprecated in the 7.1.x tree, with a reference to the new project.
>>
>> Cheers,
>>
>> — Leif
>>
>>
Re: [DISCUSS] Move pagespeed plugin to the Pagespeed Incubator project
Posted by Otto van der Schaaf <os...@gmail.com>.
Yes, sure. It would probably be best to have this in a new repo, e.g.:
https://github.com/apache/incubator-pagespeed-ats.git
Do you know who do I need to contact to see if initializing a new repo is
possible?
Otto
On Fri, Jan 19, 2018 at 7:27 AM Leif Hedstrom <zw...@apache.org> wrote:
>
>
> > On Jan 18, 2018, at 2:02 AM, Alan Carroll <so...@oath.com.INVALID>
> wrote:
> >
> > +1
>
>
> Seems like we should do this. Otto, do you want to do the honors of moving
> this to the Pagespeed Git repo? Once done, I’ll also mark the plugin as
> deprecated in the 7.1.x tree, with a reference to the new project.
>
> Cheers,
>
> — Leif
>
>
Re: [DISCUSS] Move pagespeed plugin to the Pagespeed Incubator
project
Posted by Leif Hedstrom <zw...@apache.org>.
> On Jan 18, 2018, at 2:02 AM, Alan Carroll <so...@oath.com.INVALID> wrote:
>
> +1
Seems like we should do this. Otto, do you want to do the honors of moving this to the Pagespeed Git repo? Once done, I’ll also mark the plugin as deprecated in the 7.1.x tree, with a reference to the new project.
Cheers,
— Leif
Re: [DISCUSS] Move pagespeed plugin to the Pagespeed Incubator project
Posted by Alan Carroll <so...@oath.com.INVALID>.
+1
On Tue, Jan 16, 2018 at 5:30 PM, Otto van der Schaaf <os...@gmail.com>
wrote:
> +1, I will be happy to help integrate it into the pagespeed codebase, it
> will make proper maintenance much easier indeed
>
> Otto
> On Tue, 16 Jan 2018 at 23:35, James Peach <jp...@apache.org> wrote:
>
> >
> >
> > > On Jan 16, 2018, at 11:11 AM, Leif Hedstrom <zw...@apache.org> wrote:
> > >
> > > Hi all,
> > >
> > > The Pagespeed project recently moved from Google over to the Apache
> > Incubator! I’d like to move our ATS plugin over to their project for
> v8.0.
> > This is simply to make it a lot easier to build, and maintain, the ATS
> > Pagespeed plugin. It also allows for a much better integration with the
> > library development and releases.
> > >
> > > Any concerns ?
> >
> > Assuming the page speed project and ATS plugin maintainers are on board,
> > this sounds like a good idea.
> >
> > J
>
Re: [DISCUSS] Move pagespeed plugin to the Pagespeed Incubator project
Posted by Otto van der Schaaf <os...@gmail.com>.
+1, I will be happy to help integrate it into the pagespeed codebase, it
will make proper maintenance much easier indeed
Otto
On Tue, 16 Jan 2018 at 23:35, James Peach <jp...@apache.org> wrote:
>
>
> > On Jan 16, 2018, at 11:11 AM, Leif Hedstrom <zw...@apache.org> wrote:
> >
> > Hi all,
> >
> > The Pagespeed project recently moved from Google over to the Apache
> Incubator! I’d like to move our ATS plugin over to their project for v8.0.
> This is simply to make it a lot easier to build, and maintain, the ATS
> Pagespeed plugin. It also allows for a much better integration with the
> library development and releases.
> >
> > Any concerns ?
>
> Assuming the page speed project and ATS plugin maintainers are on board,
> this sounds like a good idea.
>
> J
Re: [DISCUSS] Move pagespeed plugin to the Pagespeed Incubator
project
Posted by James Peach <jp...@apache.org>.
> On Jan 16, 2018, at 11:11 AM, Leif Hedstrom <zw...@apache.org> wrote:
>
> Hi all,
>
> The Pagespeed project recently moved from Google over to the Apache Incubator! I’d like to move our ATS plugin over to their project for v8.0. This is simply to make it a lot easier to build, and maintain, the ATS Pagespeed plugin. It also allows for a much better integration with the library development and releases.
>
> Any concerns ?
Assuming the page speed project and ATS plugin maintainers are on board, this sounds like a good idea.
J