[GitHub] kaxil edited a comment on issue #4513: [AIRFLOW-3697] Vendorize nvd3 and slugify

[GitBox <gi...@apache.org>]

kaxil edited a comment on issue #4513: [AIRFLOW-3697] Vendorize nvd3 and slugify
URL: https://github.com/apache/airflow/pull/4513#issuecomment-453880447
 
 
   I would suggest if this needs more work and probably more time we can include it in the next release. We can have a patch release 1.10.3 after fixing this issue. Let me know your thoughts on this if you agree I will cut RCs for 1.10.2.
   
   CI fails with similar errors as below:
   
   ```
   ======================================================================
   1) ERROR: test_backfill (tests.CliTests)
   ----------------------------------------------------------------------
      Traceback (most recent call last):
       tests/core.py line 1073 in setUp
         self.app, self.appbuilder = application.create_app(session=Session, testing=True)
       airflow/www_rbac/app.py line 163 in create_app
         init_views(appbuilder)
       airflow/www_rbac/app.py line 91 in init_views
         from airflow.www_rbac import views
       airflow/www_rbac/views.py line 65 in <module>
         from airflow._vendor import nvd3
       airflow/_vendor/nvd3/__init__.py line 19 in <module>
         from .lineChart import lineChart
       airflow/_vendor/nvd3/lineChart.py line 12 in <module>
         from .NVD3Chart import NVD3Chart, TemplateMixin
       airflow/_vendor/nvd3/NVD3Chart.py line 26 in <module>
         pl = PackageLoader('nvd3', 'templates')
       .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/jinja2/loaders.py line 224 in __init__
         provider = get_provider(package_name)
       .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/pkg_resources/__init__.py line 359 in get_provider
         __import__(moduleOrReq)
      ImportError: No module named nvd3
   
   ======================================================================
   2) ERROR: test_cli_connections_add_delete (tests.CliTests)
   ----------------------------------------------------------------------
      Traceback (most recent call last):
       tests/core.py line 1073 in setUp
         self.app, self.appbuilder = application.create_app(session=Session, testing=True)
       airflow/www_rbac/app.py line 163 in create_app
         init_views(appbuilder)
       airflow/www_rbac/app.py line 91 in init_views
         from airflow.www_rbac import views
       airflow/www_rbac/views.py line 65 in <module>
         from airflow._vendor import nvd3
       airflow/_vendor/nvd3/__init__.py line 19 in <module>
         from .lineChart import lineChart
       airflow/_vendor/nvd3/lineChart.py line 12 in <module>
         from .NVD3Chart import NVD3Chart, TemplateMixin
       airflow/_vendor/nvd3/NVD3Chart.py line 26 in <module>
         pl = PackageLoader('nvd3', 'templates')
       .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/jinja2/loaders.py line 224 in __init__
         provider = get_provider(package_name)
       .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/pkg_resources/__init__.py line 359 in get_provider
         __import__(moduleOrReq)
      ImportError: No module named nvd3
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services