[GitHub] [spark] cloud-fan commented on a change in pull request #33173: [SPARK-35971][SQL] Rename the type name of TimestampNTZType as "timestamp_ntz"

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #33173:
URL: https://github.com/apache/spark/pull/33173#discussion_r662115165



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/TimestampNTZType.scala
##########
@@ -48,7 +48,7 @@ class TimestampNTZType private() extends AtomicType {
    */
   override def defaultSize: Int = 8
 
-  override def typeName: String = "timestamp without time zone"
+  override def typeName: String = "timestamp_ntz"

Review comment:
       +1, this is also used when serializing a DataType to JSON, so removing the spaces is more robust.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org