You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2022/05/02 23:58:17 UTC
[kudu-CR] jwt: add control points for test binaries
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18476
Change subject: jwt: add control points for test binaries
......................................................................
jwt: add control points for test binaries
This hooks the configurations of the MiniOidc into the Java test binary,
allowing test code to add statically-defined JWKS associated with
specific account IDs, to be fetched via OIDC Discovery Endpoint.
Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
4 files changed, 96 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/18476/1
--
To view, visit http://gerrit.cloudera.org:8080/18476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 18476
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] jwt: add control points for test binaries
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#3) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18476 )
Change subject: jwt: add control points for test binaries
......................................................................
jwt: add control points for test binaries
This hooks the configurations of the MiniOidc into the Java test binary,
allowing test code to add statically-defined JWKS associated with
specific account IDs, to be fetched via OIDC Discovery Endpoint.
Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
5 files changed, 93 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/18476/3
--
To view, visit http://gerrit.cloudera.org:8080/18476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 18476
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <an...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] jwt: add control points for test binaries
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18476 )
Change subject: jwt: add control points for test binaries
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18476/5/java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java:
http://gerrit.cloudera.org:8080/#/c/18476/5/java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java@120
PS5, Line 120: KuduClient client = new KuduClientBuilder(cluster.getMasterAddressesAsString()).build()) {
> nit: indent here and below
I think this ident is correct, line 120 belongs to the try ()
--
To view, visit http://gerrit.cloudera.org:8080/18476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 18476
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <an...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Apr 2023 14:01:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] jwt: add control points for test binaries
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18476 )
Change subject: jwt: add control points for test binaries
......................................................................
jwt: add control points for test binaries
This hooks the configurations of the MiniOidc into the Java test binary,
allowing test code to add statically-defined JWKS associated with
specific account IDs, to be fetched via OIDC Discovery Endpoint.
Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Reviewed-on: http://gerrit.cloudera.org:8080/18476
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
5 files changed, 94 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 18476
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <an...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] jwt: add control points for test binaries
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18476 )
Change subject: jwt: add control points for test binaries
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18476/5/java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java:
http://gerrit.cloudera.org:8080/#/c/18476/5/java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java@120
PS5, Line 120: KuduClient client = new KuduClientBuilder(cluster.getMasterAddressesAsString()).build()) {
nit: indent here and below
--
To view, visit http://gerrit.cloudera.org:8080/18476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 18476
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <an...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Apr 2023 13:50:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] jwt: add control points for test binaries
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#5) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18476 )
Change subject: jwt: add control points for test binaries
......................................................................
jwt: add control points for test binaries
This hooks the configurations of the MiniOidc into the Java test binary,
allowing test code to add statically-defined JWKS associated with
specific account IDs, to be fetched via OIDC Discovery Endpoint.
Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
5 files changed, 94 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/18476/5
--
To view, visit http://gerrit.cloudera.org:8080/18476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 18476
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <an...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] jwt: add control points for test binaries
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#4) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18476 )
Change subject: jwt: add control points for test binaries
......................................................................
jwt: add control points for test binaries
This hooks the configurations of the MiniOidc into the Java test binary,
allowing test code to add statically-defined JWKS associated with
specific account IDs, to be fetched via OIDC Discovery Endpoint.
Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
5 files changed, 94 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/18476/4
--
To view, visit http://gerrit.cloudera.org:8080/18476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 18476
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <an...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] jwt: add control points for test binaries
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18476 )
Change subject: jwt: add control points for test binaries
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 18476
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <an...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Apr 2023 14:13:29 +0000
Gerrit-HasComments: No
[kudu-CR] jwt: add control points for test binaries
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18476 )
Change subject: jwt: add control points for test binaries
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18476/5/java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java:
http://gerrit.cloudera.org:8080/#/c/18476/5/java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java@120
PS5, Line 120: KuduClient client = new KuduClientBuilder(cluster.getMasterAddressesAsString()).build()) {
> nit: indent here and below
never mind, I can't read :)
--
To view, visit http://gerrit.cloudera.org:8080/18476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 18476
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <an...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Apr 2023 14:00:55 +0000
Gerrit-HasComments: Yes