[GitHub] [rocketmq] RongtongJin commented on a change in pull request #3828: [ISSUE #3827]Improve Performance of Transactional Message

[GitBox <gi...@apache.org>]

RongtongJin commented on a change in pull request #3828:
URL: https://github.com/apache/rocketmq/pull/3828#discussion_r802188149



##########
File path: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
##########
@@ -510,17 +511,20 @@ private boolean isLmqConsumeQueueNumExceeded() {
     @Override
     public PutMessageResult putMessage(MessageExtBrokerInner msg) {
         try {
-            return asyncPutMessage(msg).get();
-        } catch (InterruptedException | ExecutionException e) {
+            // to make sure put timeout bigger than flush timeout, full gc is also considered
+            int putTimeout  = this.messageStoreConfig.getSyncFlushTimeout() + 5000;

Review comment:
       IMO, it would be better to add a new messageStoreConfig like putMessageTimeout than using syncFlushTimeout + 5000.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org