You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jiri Kuhn (JIRA)" <ji...@apache.org> on 2007/01/22 15:30:32 UTC
[jira] Created: (LUCENE-780) Generalize directory copy operation
Generalize directory copy operation
-----------------------------------
Key: LUCENE-780
URL: https://issues.apache.org/jira/browse/LUCENE-780
Project: Lucene - Java
Issue Type: Improvement
Components: Store
Reporter: Jiri Kuhn
Priority: Minor
The copy operation in RAMDirectory(Directory) constructor can be used more generally to copy one directory to another. Why bound it only to RAMDirectory?. For example, I build index in RAMDirectory but I need it to persist in FSDirectory. I created a patch to solve it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-780) Generalize directory copy operation
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466522 ]
Michael McCandless commented on LUCENE-780:
-------------------------------------------
I agree, moving this up to Directory from RAMDirectory makes sense.
The patch applies cleanly and all tests pass.
I will make a small change to do the is.close/os.close in a "finally" clause, and then I'll commit it.
Thanks Jiri!
> Generalize directory copy operation
> -----------------------------------
>
> Key: LUCENE-780
> URL: https://issues.apache.org/jira/browse/LUCENE-780
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Reporter: Jiri Kuhn
> Priority: Minor
> Attachments: DirectoryCopy.patch
>
>
> The copy operation in RAMDirectory(Directory) constructor can be used more generally to copy one directory to another. Why bound it only to RAMDirectory?. For example, I build index in RAMDirectory but I need it to persist in FSDirectory. I created a patch to solve it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-780) Generalize directory copy operation
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-780.
---------------------------------------
Resolution: Fixed
Fix Version/s: 2.1
Lucene Fields: [New, Patch Available] (was: [Patch Available, New])
OK I committed this. I added the try/finally and made some small changes to the javadoc.
Thanks Jiri and keep the patches coming!
> Generalize directory copy operation
> -----------------------------------
>
> Key: LUCENE-780
> URL: https://issues.apache.org/jira/browse/LUCENE-780
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Reporter: Jiri Kuhn
> Priority: Minor
> Fix For: 2.1
>
> Attachments: DirectoryCopy.patch
>
>
> The copy operation in RAMDirectory(Directory) constructor can be used more generally to copy one directory to another. Why bound it only to RAMDirectory?. For example, I build index in RAMDirectory but I need it to persist in FSDirectory. I created a patch to solve it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-780) Generalize directory copy operation
Posted by "Jiri Kuhn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jiri Kuhn updated LUCENE-780:
-----------------------------
Attachment: DirectoryCopy.patch
> Generalize directory copy operation
> -----------------------------------
>
> Key: LUCENE-780
> URL: https://issues.apache.org/jira/browse/LUCENE-780
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Reporter: Jiri Kuhn
> Priority: Minor
> Attachments: DirectoryCopy.patch
>
>
> The copy operation in RAMDirectory(Directory) constructor can be used more generally to copy one directory to another. Why bound it only to RAMDirectory?. For example, I build index in RAMDirectory but I need it to persist in FSDirectory. I created a patch to solve it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org