You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/09/18 02:26:06 UTC
[GitHub] couchdb-fauxton pull request: Update two_pane template to use flex...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/528
Update two_pane template to use flexbox
This updates the CSS for two_pane to remove the old
layout CSS and use flexbox.
Impact:
- Cloudant Query page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton flexbox-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/528.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #528
----
commit 6b9a02a3bfaa3a44ca6bbd9e8a482785791df84a
Author: Ben Keen <be...@gmail.com>
Date: 2015-09-18T00:23:00Z
Update two_pane template to use flexbox
This updates the CSS for two_pane to remove the old
layout CSS and use flexbox.
Impact:
- Cloudant Query page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update two_pane template to use flex...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/528#discussion_r40092100
--- Diff: app/addons/documents/mango/mango.components.react.jsx ---
@@ -129,7 +129,7 @@ function (app, FauxtonAPI, React, Stores, Actions,
var url = '#/' + FauxtonAPI.urls('allDocs', 'app', this.props.dbName, '');
return (
- <div className="editor-wrapper span5 scrollable">
+ <div className="editor-wrapper">
--- End diff --
i guess this change has also to be made to the index-editor?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update two_pane template to use flex...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/528#discussion_r40092135
--- Diff: app/addons/documents/mango/mango.components.react.jsx ---
@@ -129,7 +129,7 @@ function (app, FauxtonAPI, React, Stores, Actions,
var url = '#/' + FauxtonAPI.urls('allDocs', 'app', this.props.dbName, '');
return (
- <div className="editor-wrapper span5 scrollable">
+ <div className="editor-wrapper">
--- End diff --
aka view-editor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update two_pane template to use flex...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/528#issuecomment-143127584
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update two_pane template to use flex...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/528#discussion_r40359926
--- Diff: app/addons/documents/mango/mango.components.react.jsx ---
@@ -129,7 +129,7 @@ function (app, FauxtonAPI, React, Stores, Actions,
var url = '#/' + FauxtonAPI.urls('allDocs', 'app', this.props.dbName, '');
return (
- <div className="editor-wrapper span5 scrollable">
+ <div className="editor-wrapper">
--- End diff --
Actually not yet. The index-editor doesn't use two_pane yet, so the flexbox refactor will change that in a later commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update two_pane template to use flex...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/528
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update two_pane template to use flex...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/528#issuecomment-144499400
Thanks @michellephung. Just rebased with master. Will merge shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---