[GitHub] [spark] cloud-fan commented on a change in pull request #32361: [SPARK-35240][SS] Use CheckpointFileManager for checkpoint file manipulation

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #32361:
URL: https://github.com/apache/spark/pull/32361#discussion_r622103974



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CheckpointFileManager.scala
##########
@@ -83,6 +83,9 @@ trait CheckpointFileManager {
 
   /** Is the default file system this implementation is operating on the local file system. */
   def isLocal: Boolean
+
+  /** Returns a qualified path object for the file system's working directory. */
+  def makeQualified(path: Path): Path

Review comment:
       This trait has many APIs that take a `Path` parameter. Should it be a qualified path or a relative path? `CheckpointFileManager.create` takes the checkpoint location, which makes me think that all the APIs should take relative paths, implementation should qualify the path internally.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org