You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bugraoz93 (via GitHub)" <gi...@apache.org> on 2024/08/10 00:12:14 UTC
[PR] Fix Variable and KubernetesJobOperator Tests for Database Isolation [airflow]
bugraoz93 opened a new pull request, #41370:
URL: https://github.com/apache/airflow/pull/41370
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Related: #41067
Fixing remaining Variable tests for db isolation mode, and fixing secret backend that hasn't been called from `EnvironmentVariablesBackend` and `MetastoreBackend` from the tests because not sharing the same session. This caused a side effect to move the `Variable.get()` method to the internal API. `Variable.setDefault()` was the only remaining one and failed a couple of tests due to this not working with internal_api. I moved that to `Variable.setDefault()` internal_api as well since every other part of Variable moved to internal_api and underlying `Variable.set()` has been already in the internal_api. As far as I see, it won't have any side effects to move these to internal_api since we are doing everything else through internal_api for Variables. Please let me know if there would be any. Otherwise, I can revert the moving to internal_api parts and skip those tests for db-isolation.
Also includes a small fix for KubernetesJobOperator tests, I guess to pass the session.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Variable and KubernetesJobOperator Tests for Database Isolation Tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #41370:
URL: https://github.com/apache/airflow/pull/41370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Variable and KubernetesJobOperator Tests for Database Isolation Tests [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #41370:
URL: https://github.com/apache/airflow/pull/41370#discussion_r1712438214
##########
airflow/secrets/base_secrets.py:
##########
@@ -21,8 +21,11 @@
from typing import TYPE_CHECKING
from airflow.exceptions import RemovedInAirflow3Warning
+from airflow.utils.session import provide_session
if TYPE_CHECKING:
+ from sqlalchemy.orm import Session
Review Comment:
I think this is the problem. I am not sure removing type checking will solve the problem or cause more. If there won't be a session parameter at the base class that some implementations have, we can not pass the session from Variable and assume that there will always be a session parameter . Otherwise, it would fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Variable and KubernetesJobOperator Tests for Database Isolation Tests [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #41370:
URL: https://github.com/apache/airflow/pull/41370#discussion_r1712626422
##########
airflow/secrets/base_secrets.py:
##########
@@ -21,8 +21,11 @@
from typing import TYPE_CHECKING
from airflow.exceptions import RemovedInAirflow3Warning
+from airflow.utils.session import provide_session
if TYPE_CHECKING:
+ from sqlalchemy.orm import Session
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org