[GitHub] [flink] uce commented on a change in pull request #10510: [FLINK-15176][container] Add '--job-classname' to flink-container 'jo…

[GitBox <gi...@apache.org>]

uce commented on a change in pull request #10510: [FLINK-15176][container] Add '--job-classname' to flink-container 'jo…
URL: https://github.com/apache/flink/pull/10510#discussion_r367357665
 
 

 ##########
 File path: flink-container/kubernetes/job-cluster-job.yaml.template
 ##########
 @@ -31,7 +31,7 @@ spec:
       containers:
       - name: flink-job-cluster
         image: ${FLINK_IMAGE_NAME}
-        args: ["job-cluster", "-Djobmanager.rpc.address=flink-job-cluster",
+        args: ["job-cluster", "--job-classname=${JOB_CLASSNAME}", "-Djobmanager.rpc.address=flink-job-cluster",
 
 Review comment:
   I don't think we always want to set the job class name here. We scan the class path for a JAR with a main class manifest entry. Therefore, the job cluster entry point should figure out automatically which class to run in the common case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services