You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "X-LightYear (via GitHub)" <gi...@apache.org> on 2026/09/22 13:04:09 UTC

[PR] fix(studio): escape paginated topic system prefixes [rocketmq-dashboard]

X-LightYear opened a new pull request, #4955:
URL: https://github.com/apache/rocketmq-dashboard/pull/4955

## Summary

- escape the three hard-coded system-topic prefix patterns used by paginated topic queries
- keep legal user topics containing RETRY, DLQ, or similar rmq_sys text visible
- add deterministic regression coverage for the generated SQL parameters

## Root cause

`RocketMQMetadataProvider.listTopicsPage` passed literal RocketMQ prefixes to MyBatis-Plus `notLikeRight`. The `%` characters in `%RETRY%` and `%DLQ%`, and the `_` in `rmq_sys_`, were therefore interpreted as SQL LIKE wildcards. The paginated endpoint could omit legal user topics and report an incorrect total.

## Fix

Use explicit `NOT LIKE ... ESCAPE CHAR(92)` predicates with escaped literal prefix patterns. The existing non-paginated path already classifies these names as system topics using literal prefix checks; the paginated path now has equivalent semantics.

## Testing

- `mvn -Dtest=RocketMQMetadataProviderTest#listTopicsPageShouldTreatSystemPrefixesAsLiteralPatternsTest test` ? passed
- `mvn -Dtest=RocketMQMetadataProviderTest test` ? 44 passed
- H2 in MySQL mode SQL boundary check ? passed
- `git diff --check` ? passed
- full `mvn test` reached 2415 tests but had 3 failures and 22 errors in unrelated integration contexts because local MySQL rejected the configured root credentials

Fixes #4952

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(studio): escape paginated topic system prefixes [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #4955:
URL: https://github.com/apache/rocketmq-dashboard/pull/4955#issuecomment-6071667341

   This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(studio): escape paginated topic system prefixes [rocketmq-dashboard]

Posted by "X-LightYear (via GitHub)" <gi...@apache.org>.

X-LightYear commented on PR #4955:
URL: https://github.com/apache/rocketmq-dashboard/pull/4955#issuecomment-5930725006

   @lizhimins Thanks for the review. I rebuilt the branch on the latest `rocketmq-studio` base and addressed both requested changes: the paginated query now keeps the typed `notLikeRight` lambda predicates while escaping literal `%` and `_` values, and the PR description no longer claims semantic equivalence with the non-paginated `SystemTopicFilter`. The focused regression, `RocketMQMetadataProviderTest` (47 tests), `MetadataServiceTest` plus `ApacheInstanceProviderTest` (64 tests), Checkstyle, compile, JAR/repackage, and `git diff --check` pass. The final package gate is only blocked by the environment missing `python3` for the existing binary-license check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(studio): escape paginated topic system prefixes [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] closed pull request #4955: fix(studio): escape paginated topic system prefixes
URL: https://github.com/apache/rocketmq-dashboard/pull/4955


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org