You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/03/27 15:05:18 UTC
[GitHub] [cordova-android] breautek opened a new pull request #1179: add repositories support
breautek opened a new pull request #1179:
URL: https://github.com/apache/cordova-android/pull/1179
This is to correct a big rebase booboo.
Original PR and credit goes to https://github.com/apache/cordova-android/pull/867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #1179: feat: add custom repositories support
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1179:
URL: https://github.com/apache/cordova-android/pull/1179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] goffioul commented on pull request #1179: feat: add custom repositories support
Posted by GitBox <gi...@apache.org>.
goffioul commented on pull request #1179:
URL: https://github.com/apache/cordova-android/pull/1179#issuecomment-820486928
As it has been pushed as a minor release, it would probably have been wiser to make the `apply from:` statement in `allprojects` conditional to the existence of `repositories.gradle`. If you, like me, construct your cordova project with local dependencies/subprojects, then this change breaks the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1179: feat: add custom repositories support
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1179:
URL: https://github.com/apache/cordova-android/pull/1179#issuecomment-819215849
@mattdsteele please also read the description of the original PR, which the link can be found in this PR's description. It will contain the `config.xml` the setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] dirien commented on pull request #1179: feat: add custom repositories support
Posted by GitBox <gi...@apache.org>.
dirien commented on pull request #1179:
URL: https://github.com/apache/cordova-android/pull/1179#issuecomment-819214774
Hi @mattdsteele , just add "your" repos to the repositories.gradle. It will pick them up from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] mattdsteele commented on pull request #1179: feat: add custom repositories support
Posted by GitBox <gi...@apache.org>.
mattdsteele commented on pull request #1179:
URL: https://github.com/apache/cordova-android/pull/1179#issuecomment-819158423
@breautek This looks amazing, I am so excited to use this! Is there any documentation or examples of how a to apply a custom registry? It's unclear to me what I should modify, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on pull request #1179: feat: add custom repositories support
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1179:
URL: https://github.com/apache/cordova-android/pull/1179#issuecomment-808747235
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1179?src=pr&el=h1) Report
> Merging [#1179](https://codecov.io/gh/apache/cordova-android/pull/1179?src=pr&el=desc) (ddcb493) into [master](https://codecov.io/gh/apache/cordova-android/commit/1430304d367e7c4a4250d9351726023e87b0088a?el=desc) (1430304) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1179 +/- ##
=======================================
Coverage 73.30% 73.30%
=======================================
Files 22 22
Lines 1768 1768
=======================================
Hits 1296 1296
Misses 472 472
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1179?src=pr&el=footer). Last update [1430304...ddcb493](https://codecov.io/gh/apache/cordova-android/pull/1179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] goffioul commented on pull request #1179: feat: add custom repositories support
Posted by GitBox <gi...@apache.org>.
goffioul commented on pull request #1179:
URL: https://github.com/apache/cordova-android/pull/1179#issuecomment-823297047
> As it has been pushed as a minor release, it would probably have been wiser to make the `apply from:` statement in `allprojects` conditional to the existence of `repositories.gradle`.
E.g. a slightly more robust logic for `allprojects` could maybe be:
1. load `repositories.gradle` from current project directory
2. if file in 1. does not exist, load `repositories.gradle` from root project directory
The template project would then only need to provide a single `repositories.gradle` at the top-level and avoid having to copy the same file at multiple locations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] mattdsteele edited a comment on pull request #1179: feat: add custom repositories support
Posted by GitBox <gi...@apache.org>.
mattdsteele edited a comment on pull request #1179:
URL: https://github.com/apache/cordova-android/pull/1179#issuecomment-819158423
@breautek @dirien This looks amazing, I am so excited to use this! Is there any documentation or examples of how a to apply a custom registry? It's unclear to me what I should modify, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org