You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/04/29 01:57:35 UTC
svn commit: r1476868 -
/commons/proper/collections/trunk/src/test/java/org/apache/commons/collections4/iterators/FilterListIteratorTest.java
Author: sebb
Date: Sun Apr 28 23:57:35 2013
New Revision: 1476868
URL: http://svn.apache.org/r1476868
Log:
Ensure oddness check works even for negative numbers
Modified:
commons/proper/collections/trunk/src/test/java/org/apache/commons/collections4/iterators/FilterListIteratorTest.java
Modified: commons/proper/collections/trunk/src/test/java/org/apache/commons/collections4/iterators/FilterListIteratorTest.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/test/java/org/apache/commons/collections4/iterators/FilterListIteratorTest.java?rev=1476868&r1=1476867&r2=1476868&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/test/java/org/apache/commons/collections4/iterators/FilterListIteratorTest.java (original)
+++ commons/proper/collections/trunk/src/test/java/org/apache/commons/collections4/iterators/FilterListIteratorTest.java Sun Apr 28 23:57:35 2013
@@ -65,7 +65,7 @@ public class FilterListIteratorTest exte
for (int i = 0; i < 20; i++) {
list.add(Integer.valueOf(i));
if (i % 2 == 0) { evens.add(Integer.valueOf(i)); }
- if (i % 2 == 1) { odds.add(Integer.valueOf(i)); }
+ if (i % 2 != 0) { odds.add(Integer.valueOf(i)); }
if (i % 3 == 0) { threes.add(Integer.valueOf(i)); }
if (i % 4 == 0) { fours.add(Integer.valueOf(i)); }
if (i % 6 == 0) { sixes.add(Integer.valueOf(i)); }
@@ -91,7 +91,7 @@ public class FilterListIteratorTest exte
oddPred = new Predicate<Integer>() {
public boolean evaluate(final Integer x) {
- return x % 2 == 1;
+ return x % 2 != 0; //works for all numbers, not just >= 0 as is the case for "x % 2 == 1"
}
};