[GitHub] [nifi] mattyb149 commented on a change in pull request #4266: Nifi-7403 PutSQL improvement

[GitBox <gi...@apache.org>]

mattyb149 commented on a change in pull request #4266:
URL: https://github.com/apache/nifi/pull/4266#discussion_r432677193



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutSQL.java
##########
@@ -173,12 +192,10 @@ public void testFailInMiddleWithBadStatement() throws InitializationException, P
         runner.enqueue("INSERT INTO PERSONS_AI".getBytes()); // intentionally wrong syntax
         runner.enqueue("INSERT INTO PERSONS_AI (NAME, CODE) VALUES ('Tom', 3)".getBytes());
         runner.enqueue("INSERT INTO PERSONS_AI (NAME, CODE) VALUES ('Harry', 44)".getBytes());
-        runner.run();
-
-        runner.assertTransferCount(PutSQL.REL_FAILURE, 1);

Review comment:
       Should we be asserting something different here? Doesn't seem like we'd need this test otherwise, since we're not running the flow or verifying any results.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org