[jira] [Updated] (DERBY-5971) Improve test coverage for SQLBoolean class

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-5971:
--------------------------------------

    Attachment: d5971-2a-hashCode.diff

Attaching a patch that adds a test case which exercises the hashCode() method by performing a SELECT DISTINCT query.

Committed revision 1406125.
                
> Improve test coverage for SQLBoolean class
> ------------------------------------------
>
>                 Key: DERBY-5971
>                 URL: https://issues.apache.org/jira/browse/DERBY-5971
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.10.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5971-1a-unused-and-binary-operators.diff, d5971-2a-hashCode.diff
>
>
> When looking at a test coverage report, I noticed that these methods in the SQLBoolean class are not tested:
> - falseTruthValue
> - trueTruthValue
> - greaterOrEquals
> - greaterThan
> - lessOrEquals
> - lessThan
> - is
> - isNot
> - readExternal
> - hashCode
> falseTruthValue() and trueTruthValue() are never called anywhere in the code and could be removed.
> is() and isNot() also have no callers. However, they implement the boolean IS operator which is part of the SQL standard, so it might make more sense to file a JIRA to add the syntax to the grammar rather than removing the methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira