You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Serge Knystautas <se...@lokitech.com> on 2002/12/20 15:18:15 UTC
pop3-file bug
I'm going to create a branch and stick the fix in there. When the
community is ready, they can choose to add it or not.
--
Serge Knystautas
Loki Technologies - Unstoppable Websites
http://www.lokitech.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: pop3-file bug
Posted by "Noel J. Bergman" <no...@devtech.com>.
> It's very easy to fix the numbering... but some work to offer backwards
> compatibility.
The numbering fix looked trivial from Iwasa Kazmi's patch
(http://nagoya.apache.org/eyebrowse/ReadMsg?listName=james-dev@jakarta.apach
e.org&msgId=572609).
What is the issue with backwards compatibility if the file system repository
is broken between reboots anyway? And what, if any, impact does this have
on dbfile (I have not looked at the code in a while)?
Have you been testing this change? How quickly can you post the change? I
would like to call for a vote on whether or not to release v2.1 now, with
fragile file system repositories, or apply the fix first. However, before
doing so, can you give us a target for when you can submit the changes? If
we can ship James v2.1 by end of week, I, personally, would be satisifed.
> If we had that tool I've been yearing for that would let admins easily
> move files between repositories ...
Wanna work on it? :-) Actually, I might help. Frustrates me, too. I want
to be able to re-queue false positives from the spam filters, or
mis-addressed e-mail.
--- Noel
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: pop3-file bug
Posted by Serge Knystautas <se...@lokitech.com>.
> I have no problem with a CVS branch, if that's the correct technical CVS
> approach. If I ever pretend to be a CVS expert, let me know. ;-)
> Hopefully we'll move to Subversion long before that day. Personally, I
> liked and used SourceSafe prior to its acquisition.
>
> IAE, I was more interested in how we resolve the problem within the code,
> than how we represent it for the time being in the source code repository.
Ah yes, well your steps were pretty close to what I had said needed to be
done in the original bug report, so I thought you had pulled from that. I
pretty much finished the patch, so I can tell you what I had to do...
There are basically two changes:
1. I copied over the blocks implementation to a new
org.apache.james.mailrepository.filepair package (there are 4 files...
stream and object repository, a repository manager, and an abstract
repository). Then changed that to not number the repository (but still read
the numbered messages).
2. Then you change your james-config.xml file to have file:// load the file
repositories implementation from the new package.
It's very easy to fix the numbering... but some work to offer backwards
compatibility. If we had that tool I've been yearing for that would let
admins easily move files between repositories, we could offer backwards
compatibility with a migration process... define filenumbered:// and file://
to be the avalon and the james implementations, respectively, and then have
admins transfer from one implementation to the other.
Serge Knystatuas
Loki Technologies
http://www.lokitech.com/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: pop3-file bug
Posted by "Noel J. Bergman" <no...@devtech.com>.
Serge,
I have no problem with a CVS branch, if that's the correct technical CVS
approach. If I ever pretend to be a CVS expert, let me know. ;-)
Hopefully we'll move to Subversion long before that day. Personally, I
liked and used SourceSafe prior to its acquisition.
IAE, I was more interested in how we resolve the problem within the code,
than how we represent it for the time being in the source code repository.
--- Noel
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: pop3-file bug
Posted by Serge Knystautas <se...@lokitech.com>.
Noel J. Bergman wrote:
> Serge,
>
> Did you see my post on how I recommend that we fix it?
>
> --- Noel
Noel,
You mean the process (moving the classes over, testing, fixing,
testing?). Yes I did, but I thought a CVS branch would be less
obtrusive and make it easy to add whenever it was appropriate. It would
avoid affecting the release in any way, and since as you say most people
acknowledge it's a bug and more a question of when rather than if,
putting it into a CVS branch seemed an easy way to do it.
--
Serge Knystautas
Loki Technologies - Unstoppable Websites
http://www.lokitech.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: pop3-file bug
Posted by "Noel J. Bergman" <no...@devtech.com>.
Serge,
Did you see my post on how I recommend that we fix it?
--- Noel
-----Original Message-----
From: Serge Knystautas [mailto:sergek@lokitech.com]
Sent: Friday, December 20, 2002 9:18
To: james-dev@jakarta.apache.org
Subject: pop3-file bug
I'm going to create a branch and stick the fix in there. When the
community is ready, they can choose to add it or not.
--
Serge Knystautas
Loki Technologies - Unstoppable Websites
http://www.lokitech.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>