You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by Abrasha <gi...@git.apache.org> on 2016/11/22 22:04:48 UTC

[GitHub] commons-lang pull request #215: Separate test cases by a new line.

GitHub user Abrasha opened a pull request:

    https://github.com/apache/commons-lang/pull/215

    Separate test cases by a new line.

    As you can see on screenshots it was quiet hard to maintain each test case separately. But now it is more readable.
    
    ![before](https://cloud.githubusercontent.com/assets/11317222/20543869/2896f09c-b110-11e6-9070-ce2b3cc997a1.png)
    ![after](https://cloud.githubusercontent.com/assets/11317222/20543874/2f8cd70e-b110-11e6-9cc5-d38fc826332b.png)
    P.S. rename local variable name to more applicable.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Abrasha/commons-lang fix/local-variable-names

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #215
    
----
commit a3e76a308a687537ca66fccbbdd6d33597228647
Author: Andrii <aa...@gmail.com>
Date:   2016-11-22T22:00:46Z

    rename local variable name to more applicable
    separate test cases by a new line

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #215: Separate test cases by a new line.

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/215
  
    
    [![Coverage Status](https://coveralls.io/builds/8956484/badge)](https://coveralls.io/builds/8956484)
    
    Coverage increased (+0.02%) to 93.67% when pulling **a3e76a308a687537ca66fccbbdd6d33597228647 on Abrasha:fix/local-variable-names** into **b155e6461adb72087b6f575f4e01f8ca1e624a30 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #215: Separate test cases by a new line.

Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/215
  
    Thanks! \U0001f44d 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #215: Separate test cases by a new line.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/215


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---