You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by "francescotimperioss (via GitHub)" <gi...@apache.org> on 2025/12/14 16:14:38 UTC

[PR] Bump zookeeper version to fix apache/openwhish#5564 [openwhisk]

francescotimperioss opened a new pull request, #5565:
URL: https://github.com/apache/openwhisk/pull/5565

   Bump zookeeper version to allow usage of legacy LB based setup
   
   ## Description
   This OR fixes a call not found found error attempting to setup OW2 with legacy LB, even if this is not anymore the recommended setup.
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ X] I opened an issue to propose and discuss this change (#5564)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Scheduler
   - [X ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [X ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [ X] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump zookeeper version to fix apache/openwhisk#5564 [openwhisk]

Posted by "dgrove-oss (via GitHub)" <gi...@apache.org>.
dgrove-oss commented on PR #5565:
URL: https://github.com/apache/openwhisk/pull/5565#issuecomment-5198308277

   @francescotimperioss -- it looks like you figured out a fix for the elastic search problems.
   
   Since we have a clean CI, I am going to go ahead and merge this.   Does that help unblock OpenServerless?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump zookeeper version to fix apache/openwhisk#5564 [openwhisk]

Posted by "francescotimperioss (via GitHub)" <gi...@apache.org>.
francescotimperioss commented on PR #5565:
URL: https://github.com/apache/openwhisk/pull/5565#issuecomment-5208876247

   > @francescotimperioss -- it looks like you figured out a fix for the elastic search problems.
   > 
   > Since we have a clean CI, I am going to go ahead and merge this. Does that help unblock OpenServerless?
   
   Hi @dgrove-oss , yes this should help using OpenWhisk with classical LB in OpenServerless.  Thanks for the approval of this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump zookeeper version to fix apache/openwhisk#5564 [openwhisk]

Posted by "dgrove-oss (via GitHub)" <gi...@apache.org>.
dgrove-oss merged PR #5565:
URL: https://github.com/apache/openwhisk/pull/5565


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump zookeeper version to fix apache/openwhisk#5564 [openwhisk]

Posted by "francescotimperioss (via GitHub)" <gi...@apache.org>.
francescotimperioss commented on PR #5565:
URL: https://github.com/apache/openwhisk/pull/5565#issuecomment-5006287498

   After rebasing this PR with code from master branch I still get these unit Test failing, linked to ElasticSearch and i don't really understand how this could be related to the scope of the changes of this PR.
   
   `Failed tests
        * [5]ElasticSearchActivationStoreTests.
          [6]ElasticSearchActivationStore countActivationsInNamespace should
          count with option name
        * [7]ElasticSearchActivationStoreTests.
          [8]ElasticSearchActivationStore countActivationsInNamespace should
          count with since and upto
        * [9]ElasticSearchActivationStoreTests.
          [10]ElasticSearchActivationStore countActivationsInNamespace should
          count with skip
        * [11]ElasticSearchActivationStoreTests.
          [12]ElasticSearchActivationStore countActivationsInNamespace should
          should count all created activations
        * [13]ElasticSearchActivationStoreTests.
          [14]ElasticSearchActivationStore listActivationsInNamespace should
          find all entities
        * [15]ElasticSearchActivationStoreTests.
          [16]ElasticSearchActivationStore listActivationsInNamespace should
          support since and upto filters
        * [17]ElasticSearchActivationStoreTests.
          [18]ElasticSearchActivationStore listActivationsInNamespace should
          support skipping results`
   
   I also see that Unit test fails also within subsequent scheduled build execution, without any code changes. An idea about how to fix this issue? This is preventing the Apache OpenServerless to use a deployment mode that it is not requiring the Scheduler, which for some scenarios it is still a good option. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org