You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/08 07:39:14 UTC
[GitHub] [arrow] jorisvandenbossche opened a new pull request #7674: ARROW-9368: [Python] Rename predicate argument to filter in split_by_row_group()
jorisvandenbossche opened a new pull request #7674:
URL: https://github.com/apache/arrow/pull/7674
For consistency with the `filter` keyword in `to_table()` and `get_fragments()` methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7674: ARROW-9368: [Python] Rename predicate argument to filter in split_by_row_group()
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7674:
URL: https://github.com/apache/arrow/pull/7674#discussion_r451506612
##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -936,7 +936,7 @@ cdef class ParquetFileFragment(FileFragment):
Parameters
----------
- predicate : Expression, default None
+ filter : Expression, default None
Exclude RowGroups whose statistics contradicts the predicate.
Review comment:
Update this sentence? Perhaps "Only include those row groups which satisfy this predicate"
##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -936,7 +936,7 @@ cdef class ParquetFileFragment(FileFragment):
Parameters
----------
- predicate : Expression, default None
+ filter : Expression, default None
Exclude RowGroups whose statistics contradicts the predicate.
Review comment:
Update this sentence? Perhaps "Only include the row groups which satisfy this predicate"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #7674: ARROW-9368: [Python] Rename predicate argument to filter in split_by_row_group()
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #7674:
URL: https://github.com/apache/arrow/pull/7674#issuecomment-655347038
I thought to rename the C++ SplitByRowGroup as well, but apparently on the C++ side we are consistently using `predicate` (`GetFragments` also uses predicate), so for now left it as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #7674: ARROW-9368: [Python] Rename predicate argument to filter in split_by_row_group()
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #7674:
URL: https://github.com/apache/arrow/pull/7674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7674: ARROW-9368: [Python] Rename predicate argument to filter in split_by_row_group()
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7674:
URL: https://github.com/apache/arrow/pull/7674#issuecomment-655664193
Thank you @jorisvandenbossche !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7674: ARROW-9368: [Python] Rename predicate argument to filter in split_by_row_group()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7674:
URL: https://github.com/apache/arrow/pull/7674#issuecomment-655350203
https://issues.apache.org/jira/browse/ARROW-9368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org